Skip to content

Conversation

@earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Dec 19, 2024

At the end of a cycle, the non-generational mode usage report has an errant reference to 'generation':

GC(1) At end of GC: generation used: 835M ...

After this change, the message is:

GC(0) At end of GC: used: 1793K ...

The message is unchanged for the generational mode:

GC(0) At end of Concurrent Global GC: Young generation used: 1544K ...
GC(0) At end of Concurrent Global GC: Old generation used: 0B ...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346690: Shenandoah: Fix log message for end of GC usage report (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22839/head:pull/22839
$ git checkout pull/22839

Update a local copy of the PR:
$ git checkout pull/22839
$ git pull https://git.openjdk.org/jdk.git pull/22839/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22839

View PR using the GUI difftool:
$ git pr show -t 22839

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22839.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346690: Shenandoah: Fix log message for end of GC usage report

Reviewed-by: ysr, kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • bcb1bda: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path
  • 054c644: 8346667: Doccheck: warning about missing before

  • 2a68f74: 8346128: Comparison build fails due to difference in LabelTarget.html
  • cf28fd4: 8322983: Virtual Threads: exclude 2 tests
  • 85e024d: 8346605: AIX fastdebug build fails in memoryReserver.cpp after JDK-8345655
  • 54f3475: 8331467: FileSystems.getDefault fails with ClassNotFoundException if custom default provider is in run-time image
  • 35fafbc: 8346106: Verify.checkEQ: testing utility for recursive value verification
  • b2811a0: 8340493: Fix some Asserts failure messages
  • 4d77dba: 8346576: Remove vmTestbase/gc/memory/Nio/Nio.java from test/hotspot/jtreg/ProblemList.txt
  • 2649a97: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs
  • ... and 9 more: https://git.openjdk.org/jdk/compare/55906692e18d190a6655c7d473fe6f0e017f58fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2024
@openjdk
Copy link

openjdk bot commented Dec 19, 2024

@earthling-amzn The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 19, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2024
@earthling-amzn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2024

Going to push as commit d2a4863.
Since your change was applied there have been 19 commits pushed to the master branch:

  • bcb1bda: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path
  • 054c644: 8346667: Doccheck: warning about missing before

  • 2a68f74: 8346128: Comparison build fails due to difference in LabelTarget.html
  • cf28fd4: 8322983: Virtual Threads: exclude 2 tests
  • 85e024d: 8346605: AIX fastdebug build fails in memoryReserver.cpp after JDK-8345655
  • 54f3475: 8331467: FileSystems.getDefault fails with ClassNotFoundException if custom default provider is in run-time image
  • 35fafbc: 8346106: Verify.checkEQ: testing utility for recursive value verification
  • b2811a0: 8340493: Fix some Asserts failure messages
  • 4d77dba: 8346576: Remove vmTestbase/gc/memory/Nio/Nio.java from test/hotspot/jtreg/ProblemList.txt
  • 2649a97: 8332827: [REDO] C2: crash in compiled code because of dependency on removed range check CastIIs
  • ... and 9 more: https://git.openjdk.org/jdk/compare/55906692e18d190a6655c7d473fe6f0e017f58fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2024
@openjdk openjdk bot closed this Dec 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@earthling-amzn Pushed as commit d2a4863.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants