Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8252409: JShell: Intersection types cause NoSuchFieldError #2284

Closed
wants to merge 2 commits into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jan 28, 2021

From the bug:

jshell> var test = (Serializable & Runnable) () -> {};
test ==> $Lambda$26/0x0000000800ba4248@5910e440

jshell> test
| Exception java.lang.NoSuchFieldError: test
| at (#2:1)

jshell> test.toString()
| Exception java.lang.NoSuchFieldError: test
| at (#3:1)

The reason is that the field generated for var test = ... has type j.l.Object, but the references to it use Serializable, and hence the field is not found. The proposal is to generate the field's type as an erased type of the intersection type.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252409: JShell: Intersection types cause NoSuchFieldError

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2284/head:pull/2284
$ git checkout pull/2284

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Jan 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2021

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252409: JShell: Intersection types cause NoSuchFieldError

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 20e7df5: 8260466: Test TestHeapDumpOnOutOfMemoryError.java needs multiple @test sections
  • 11d6467: 8260407: cmp != __null && cmp->Opcode() == Op_CmpL failure with -XX:StressLongCountedLoop=200000000 in lucene
  • d07af2b: 8255531: MethodHandles::permuteArguments throws NPE when duplicating dropped arguments
  • a68c6c2: 8260579: PPC64 and S390 builds failures after JDK-8260467
  • 8752257: 8260502: [s390] NativeMovRegMem::verify() fails because it's too strict
  • 8fe1323: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed
  • ecde52e: 8260506: VersionHelper cleanup
  • a97aedf: 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code
  • 316d52c: 8260497: Shenandoah: Improve SATB flushing
  • 11a70d1: 8260426: awt debug_mem.c DMem_AllocateBlock might leak memory
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/1c77046811ccf3014127c9775944156e23b93058...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 28, 2021
@lahodaj
Copy link
Contributor Author

lahodaj commented Jan 29, 2021

/integrate

@openjdk openjdk bot closed this Jan 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@lahodaj Since your change was applied there have been 46 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 0675473.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
2 participants