8260581: IGV: enhance node search #2285
Apply several enhancements to the quick node search functionality:
As an illustration of some of these enhancements, this screenshot shows the behavior of the quick node search functionality before the changes:
Tested manually on small and large (~10000 nodes) graphs. Thanks to Christian Hagedorn for feedback on several iterations of the enhancements.
As part of the review, please evaluate not just the code changes but also the usability.
The text was updated successfully, but these errors were encountered:
Change the default quick search property to "label", to allow users to search by node id or name by default, instead of name only. Re-compute the "label" property every time node labels are updated.
Adding an explicit "Recent Searches" category rather than the default, implicit one triggers two issues: - IGV does not show the recent searches when clicking into the search bar. - IGV selects random nodes in the list of matches instead of the top one.
@robcasloz This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 80 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @iwanowww) but any other Committer may sponsor as well.
Sort otherwise equally relevant matches by node id, which is by default the first word in node labels. Thanks to Christian Hagedorn for the suggestion and (slightly adapted) patch.
Your commit was automatically rebased without conflicts.
Pushed as commit ae2c5f0.