Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java #2286

Closed
wants to merge 1 commit into from
Closed

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java #2286

wants to merge 1 commit into from

Conversation

xpbob
Copy link

@xpbob xpbob commented Jan 28, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2286/head:pull/2286
$ git checkout pull/2286

@bridgekeeper bridgekeeper bot added the oca label Jan 28, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 28, 2021

Hi @xpbob, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user xpbob" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@xpbob The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jan 28, 2021
@xpbob
Copy link
Author

@xpbob xpbob commented Jan 28, 2021

/covered

@bridgekeeper bridgekeeper bot added the oca-verify label Jan 28, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 28, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@xpbob
Copy link
Author

@xpbob xpbob commented Jan 28, 2021

/issue add JDK-8260576
/label add hotspot-compiler
/cc hotspot-compiler

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@xpbob This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@xpbob The hotspot-compiler label was already applied.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@xpbob The hotspot-compiler label was already applied.

@xpbob
Copy link
Author

@xpbob xpbob commented Jan 28, 2021

/covered by Tencent

@@ -47,7 +47,7 @@ public static void main(String args[]) throws Exception {
// Check result
for (int i = 0; i < array.length; i++) {
if (array[i] != 10_000) {
throw new RuntimeException("Test failed: array[" + i + "] = " + array[i] + " but should be 10.000");
throw new RuntimeException("Test failed: array[" + i + "] = " + array[i] + " but should be 10,000");
Copy link
Member

@TobiHartmann TobiHartmann Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

. is simply the (German) thousands separator. Not sure it's really worth it changing it to a ,. But given the exception message is in English, looks good to me.

@bridgekeeper bridgekeeper bot removed oca oca-verify labels Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java

Reviewed-by: thartmann, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • a6d9505: 8260864: ProblemList two security/krb5 tests on Linux
  • 9880c4c: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()
  • b6a7367: 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS
  • 50f9a70: 8217327: G1 Post-Cleanup region liveness printing should not print out-of-date efficiency
  • e963ebd: 8260004: Shenandoah: Rename ShenandoahMarkCompact to ShenandoahFullGC
  • df33595: 8260309: Shenandoah: Clean up ShenandoahBarrierSet
  • 181d63f: 8260522: Clean up warnings in hotspot JTReg runtime tests
  • 02d586e: 8259398: Super word not applied to a loop with byteArrayViewVarHandle
  • 80760a3: 8260669: Missing quotes in fixpath.sh
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/11a70d113e98dab39110216dd73e154bc76a8bfa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Feb 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Looks good and trivial.
Will sponsor it.

@xpbob
Copy link
Author

@xpbob xpbob commented Feb 2, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@xpbob
Your change (at version ef711a8) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Feb 2, 2021

/sponsor

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated and removed sponsor ready labels Feb 2, 2021
@openjdk openjdk bot removed the rfr label Feb 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@DamonFool @xpbob Since your change was applied there have been 57 commits pushed to the master branch:

  • a6d9505: 8260864: ProblemList two security/krb5 tests on Linux
  • 9880c4c: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()
  • b6a7367: 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS
  • 50f9a70: 8217327: G1 Post-Cleanup region liveness printing should not print out-of-date efficiency
  • e963ebd: 8260004: Shenandoah: Rename ShenandoahMarkCompact to ShenandoahFullGC
  • df33595: 8260309: Shenandoah: Clean up ShenandoahBarrierSet
  • 181d63f: 8260522: Clean up warnings in hotspot JTReg runtime tests
  • 02d586e: 8259398: Super word not applied to a loop with byteArrayViewVarHandle
  • 80760a3: 8260669: Missing quotes in fixpath.sh
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/11a70d113e98dab39110216dd73e154bc76a8bfa...master

Your commit was automatically rebased without conflicts.

Pushed as commit 54e7a64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants