8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java #2286

xpbob · 2021-01-28T11:23:22Z

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java

Reviewers

Tobias Hartmann (@TobiHartmann - Reviewer)
Jie Fu (@DamonFool - Committer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2286/head:pull/2286
$ git checkout pull/2286

bridgekeeper · 2021-01-28T11:24:13Z

Hi @xpbob, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user xpbob" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

openjdk · 2021-01-28T11:25:13Z

@xpbob The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

xpbob · 2021-01-28T11:25:18Z

/covered

bridgekeeper · 2021-01-28T11:25:24Z

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

xpbob · 2021-01-28T11:35:50Z

/issue add JDK-8260576
/label add hotspot-compiler
/cc hotspot-compiler

openjdk · 2021-01-28T11:36:29Z

@xpbob This issue is referenced in the PR title - it will now be updated.

openjdk · 2021-01-28T11:36:38Z

@xpbob The hotspot-compiler label was already applied.

openjdk · 2021-01-28T11:36:44Z

@xpbob The hotspot-compiler label was already applied.

xpbob · 2021-01-28T15:07:26Z

/covered by Tencent

TobiHartmann · 2021-01-28T15:30:17Z

test/hotspot/jtreg/compiler/runtime/safepoints/TestRegisterRestoring.java

@@ -47,7 +47,7 @@ public static void main(String args[]) throws Exception {
            // Check result
            for (int i = 0; i < array.length; i++) {
                if (array[i] != 10_000) {
-                    throw new RuntimeException("Test failed: array[" + i + "] = " + array[i] + " but should be 10.000");
+                    throw new RuntimeException("Test failed: array[" + i + "] = " + array[i] + " but should be 10,000");


. is simply the (German) thousands separator. Not sure it's really worth it changing it to a ,. But given the exception message is in English, looks good to me.

openjdk · 2021-02-01T18:43:14Z

@xpbob This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java

Reviewed-by: thartmann, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

a6d9505: 8260864: ProblemList two security/krb5 tests on Linux
9880c4c: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()
b6a7367: 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS
50f9a70: 8217327: G1 Post-Cleanup region liveness printing should not print out-of-date efficiency
e963ebd: 8260004: Shenandoah: Rename ShenandoahMarkCompact to ShenandoahFullGC
df33595: 8260309: Shenandoah: Clean up ShenandoahBarrierSet
181d63f: 8260522: Clean up warnings in hotspot JTReg runtime tests
02d586e: 8259398: Super word not applied to a loop with byteArrayViewVarHandle
80760a3: 8260669: Missing quotes in fixpath.sh
... and 47 more: https://git.openjdk.java.net/jdk/compare/11a70d113e98dab39110216dd73e154bc76a8bfa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

mlbridge · 2021-02-01T18:46:52Z

Webrevs

00: Full (ef711a8)

DamonFool

Looks good and trivial.
Will sponsor it.

xpbob · 2021-02-02T02:15:21Z

/integrate

openjdk · 2021-02-02T02:15:51Z

@xpbob
Your change (at version ef711a8) is now ready to be sponsored by a Committer.

DamonFool · 2021-02-02T02:16:17Z

/sponsor

openjdk · 2021-02-02T02:17:03Z

@DamonFool @xpbob Since your change was applied there have been 57 commits pushed to the master branch:

a6d9505: 8260864: ProblemList two security/krb5 tests on Linux
9880c4c: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()
b6a7367: 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS
50f9a70: 8217327: G1 Post-Cleanup region liveness printing should not print out-of-date efficiency
e963ebd: 8260004: Shenandoah: Rename ShenandoahMarkCompact to ShenandoahFullGC
df33595: 8260309: Shenandoah: Clean up ShenandoahBarrierSet
181d63f: 8260522: Clean up warnings in hotspot JTReg runtime tests
02d586e: 8259398: Super word not applied to a loop with byteArrayViewVarHandle
80760a3: 8260669: Missing quotes in fixpath.sh
... and 47 more: https://git.openjdk.java.net/jdk/compare/11a70d113e98dab39110216dd73e154bc76a8bfa...master

Your commit was automatically rebased without conflicts.

Pushed as commit 54e7a64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java

ef711a8

bridgekeeper bot added the oca label Jan 28, 2021

openjdk bot added the hotspot-compiler label Jan 28, 2021

bridgekeeper bot added the oca-verify label Jan 28, 2021

TobiHartmann suggested changes Jan 28, 2021

View changes

TobiHartmann approved these changes Jan 28, 2021

View changes

bridgekeeper bot removed oca oca-verify labels Feb 1, 2021

openjdk bot added ready rfr labels Feb 1, 2021

DamonFool approved these changes Feb 2, 2021

View changes

openjdk bot added the sponsor label Feb 2, 2021

openjdk bot closed this Feb 2, 2021

openjdk bot added integrated and removed sponsor ready labels Feb 2, 2021

openjdk bot removed the rfr label Feb 2, 2021

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java #2286

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java #2286

xpbob commented Jan 28, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

xpbob commented Jan 28, 2021

bridgekeeper bot commented Jan 28, 2021

xpbob commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

xpbob commented Jan 28, 2021

TobiHartmann Jan 28, 2021 •

edited

openjdk bot commented Feb 1, 2021 •

edited

mlbridge bot commented Feb 1, 2021

DamonFool left a comment

xpbob commented Feb 2, 2021

openjdk bot commented Feb 2, 2021

DamonFool commented Feb 2, 2021

openjdk bot commented Feb 2, 2021

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java #2286

8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java #2286

Conversation

xpbob commented Jan 28, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

xpbob commented Jan 28, 2021

bridgekeeper bot commented Jan 28, 2021

xpbob commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

openjdk bot commented Jan 28, 2021

xpbob commented Jan 28, 2021

TobiHartmann Jan 28, 2021 • edited

Choose a reason for hiding this comment

openjdk bot commented Feb 1, 2021 • edited

mlbridge bot commented Feb 1, 2021

Webrevs

DamonFool left a comment

xpbob commented Feb 2, 2021

openjdk bot commented Feb 2, 2021

DamonFool commented Feb 2, 2021

openjdk bot commented Feb 2, 2021

xpbob commented Jan 28, 2021 •

edited by openjdk[bot] bot

TobiHartmann Jan 28, 2021 •

edited

openjdk bot commented Feb 1, 2021 •

edited