Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346295: Update --release 24 symbol information for JDK 24 build 29 #22867

Closed

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Dec 23, 2024

Usual symbol file update for a new JDK build.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346295: Update --release 24 symbol information for JDK 24 build 29 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22867/head:pull/22867
$ git checkout pull/22867

Update a local copy of the PR:
$ git checkout pull/22867
$ git pull https://git.openjdk.org/jdk.git pull/22867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22867

View PR using the GUI difftool:
$ git pr show -t 22867

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22867.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346295: Update --release 24 symbol information for JDK 24 build 29

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 62a4544: 8205051: Poor Performance with UseNUMA when cpu and memory nodes are misaligned
  • 68c6623: 8345840: Add missing TLS handshake messages to SSLHandshake.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Dec 23, 2024
@nizarbenalla nizarbenalla marked this pull request as ready for review December 23, 2024 16:08
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature changes for late ClassFile API changes look good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 24, 2024
@nizarbenalla
Copy link
Member Author

All checks pass, thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

Going to push as commit 1a32654.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 62a4544: 8205051: Poor Performance with UseNUMA when cpu and memory nodes are misaligned
  • 68c6623: 8345840: Add missing TLS handshake messages to SSLHandshake.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 24, 2024
@openjdk openjdk bot closed this Dec 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 24, 2024
@openjdk
Copy link

openjdk bot commented Dec 24, 2024

@nizarbenalla Pushed as commit 1a32654.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the Upate-symbols-jdk24b29 branch December 24, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants