8340784 : Remove PassFailJFrame constructor with screenshots

[anass-baya]

Remove PassFailJFrame constructor with screenshots since no test is using it

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8340784: Remove PassFailJFrame constructor with screenshots (Bug - P4)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22873/head:pull/22873
$ git checkout pull/22873

Update a local copy of the PR:
$ git checkout pull/22873
$ git pull https://git.openjdk.org/jdk.git pull/22873/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22873

View PR using the GUI difftool:
$ git pr show -t 22873

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22873.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @anass-baya, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user anass-baya" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@anass-baya This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340784: Remove PassFailJFrame constructor with screenshots

Reviewed-by: aivanov, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 307 new commits pushed to the master branch:

• 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
• cba0f78: 8348387: Add fixpath if needed for user-supplied tools
• 44e5cca: 8348391: Keep case if possible for TOPDIR
• 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
• 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
• c00557f: 8345049: Remove the jmx.tabular.data.hash.map compatibility property
• 8b46db0: 8345045: Remove the jmx.remote.x.buffer.size JMX notification property
• 119899b: 8345048: Remove the jmx.extend.open.types compatibility property
• 89bfcb8: 8348308: Make fields of ListSelectionEvent final
• 17df515: 8348303: Remove repeated 'a' from ListSelectionEvent
• ... and 297 more: https://git.openjdk.org/jdk/compare/62a4544bb76aa339a8129f81d2527405a1b1e7e3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@anass-baya The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[anass-baya]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@anass-baya Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[aivanov-jdk]

Nearly good.

Please, also update the copyright year at the top of the file: 2024 → 2025.

[aivanov-jdk]

Looks good.

[mlbridge]

Webrevs

• 00: Full (13570b6a)

[aivanov-jdk]

Remove PassFailJFrame constructor with screenshots since no test is using it

The feature remains available when using the recommended builder pattern to create an instance of PassFailJFrame.

This is to discourage using constructors directly. It's easier to remove the constructor when it's not used at all.

[anass-baya]

/integrate

[openjdk]

@anass-baya
Your change (at version 13570b6) is now ready to be sponsored by a Committer.

[azvegint]

/sponsor

[openjdk]

Going to push as commit 50ca450.
Since your change was applied there have been 315 commits pushed to the master branch:

• 416d469: 8347008: beancontext package spec does not clearly explain why the API is deprecated
• 471d63c: 8343609: Broken links in java.xml
• 7f16a08: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class()
• 48ece07: 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected
• 356e2a8: 8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list
• 3ebf889: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c
• d9d2e19: 8348365: Bad format string in CLDRDisplayNamesTest
• 59e7509: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests
• 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
• cba0f78: 8348387: Add fixpath if needed for user-supplied tools
• ... and 305 more: https://git.openjdk.org/jdk/compare/62a4544bb76aa339a8129f81d2527405a1b1e7e3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint @anass-baya Pushed as commit 50ca450.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.