Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346847: [s390x] minimal build failure #22887

Closed
wants to merge 1 commit into from

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Dec 27, 2024

While working on JDK-8343884, I made sure that OptoScheduling remains disabled on s390x, but for that code was not guarded by C2-specific if-def (COMPILER2) . Which caused a build failure on minimal-vm (see JBS issue for log). This is trivial fix for that.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346847: [s390x] minimal build failure (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22887/head:pull/22887
$ git checkout pull/22887

Update a local copy of the PR:
$ git checkout pull/22887
$ git pull https://git.openjdk.org/jdk.git pull/22887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22887

View PR using the GUI difftool:
$ git pr show -t 22887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22887.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 27, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346847: [s390x] minimal build failure

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8346847 8346847: [s390x] minimal build failure Dec 27, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 27, 2024
@openjdk
Copy link

openjdk bot commented Dec 27, 2024

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 27, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2024

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 27, 2024
@offamitkumar
Copy link
Member Author

Good and trivial

Thanks Thomas for approval. I will integrate it after GHA finishes.

@offamitkumar
Copy link
Member Author

GHA failure for mac/x64 is not related to this change.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 27, 2024

Going to push as commit 807f6f7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 27, 2024
@openjdk openjdk bot closed this Dec 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 27, 2024
@openjdk
Copy link

openjdk bot commented Dec 27, 2024

@offamitkumar Pushed as commit 807f6f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@offamitkumar offamitkumar deleted the minimal_build_fix branch December 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants