-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346847: [s390x] minimal build failure #22887
Conversation
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@offamitkumar The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and trivial
Thanks Thomas for approval. I will integrate it after GHA finishes. |
GHA failure for mac/x64 is not related to this change. /integrate |
Going to push as commit 807f6f7. |
@offamitkumar Pushed as commit 807f6f7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
While working on JDK-8343884, I made sure that
OptoScheduling
remains disabled on s390x, but for that code was not guarded by C2-specific if-def (COMPILER2
) . Which caused a build failure on minimal-vm (see JBS issue for log). This is trivial fix for that.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22887/head:pull/22887
$ git checkout pull/22887
Update a local copy of the PR:
$ git checkout pull/22887
$ git pull https://git.openjdk.org/jdk.git pull/22887/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22887
View PR using the GUI difftool:
$ git pr show -t 22887
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22887.diff
Using Webrev
Link to Webrev Comment