Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346831: Remove the extra closing parenthesis in CTW Makefile #22891

Closed

Conversation

MaxXSoft
Copy link
Member

@MaxXSoft MaxXSoft commented Dec 29, 2024

Hi all,

This pull request contains a backport of commit 79958470 from the openjdk/jdk repository.

The commit being backported was authored by Qizheng Xing on 29 Dec 2024 and was reviewed by Chen Liang, Kim Barrett, Leonid Mesnik and Julian Waters.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346831: Remove the extra closing parenthesis in CTW Makefile (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22891/head:pull/22891
$ git checkout pull/22891

Update a local copy of the PR:
$ git checkout pull/22891
$ git pull https://git.openjdk.org/jdk.git pull/22891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22891

View PR using the GUI difftool:
$ git pr show -t 22891

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22891.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2024

👋 Welcome back qxing! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 29, 2024

@MaxXSoft This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346831: Remove the extra closing parenthesis in CTW Makefile

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the jdk24 branch:

  • 1399f25: 8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification
  • f45a23c: 8347605: Use spec tag to refer to IEEE 754 standard
  • f42e2c1: 8347554: [BACKOUT] C2: implement optimization for series of Add of unique value
  • 57c46ac: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set
  • 24053d9: 8347274: Gatherers.mapConcurrent exhibits undesired behavior under variable delays, interruption, and finishing
  • e76cc44: 8347407: [BACKOUT] C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash)
  • 4a623a2: 8342468: Improve API documentation for java.lang.classfile.constantpool
  • ecdc322: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
  • da74fbd: 8347006: LoadRangeNode floats above array guard in arraycopy intrinsic
  • f0a89c5: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller
  • ... and 18 more: https://git.openjdk.org/jdk/compare/bed040191bda38726b8894a3e937138eb798027d...jdk24

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 79958470e08ade2d3584748e020bd2e18092c0cf 8346831: Remove the extra closing parenthesis in CTW Makefile Dec 29, 2024
@openjdk
Copy link

openjdk bot commented Dec 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 29, 2024
@openjdk
Copy link

openjdk bot commented Dec 29, 2024

@MaxXSoft The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 29, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 29, 2024

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 14, 2025
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MaxXSoft
Copy link
Member Author

@TobiHartmann @chhagedorn Thanks for the review!

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 14, 2025
@openjdk
Copy link

openjdk bot commented Jan 14, 2025

@MaxXSoft
Your change (at version 8a22e8d) is now ready to be sponsored by a Committer.

@TobiHartmann
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 15, 2025

Going to push as commit f7858e2.
Since your change was applied there have been 29 commits pushed to the jdk24 branch:

  • 6965840: 8347646: module-info classfile missing the preview flag
  • 1399f25: 8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification
  • f45a23c: 8347605: Use spec tag to refer to IEEE 754 standard
  • f42e2c1: 8347554: [BACKOUT] C2: implement optimization for series of Add of unique value
  • 57c46ac: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set
  • 24053d9: 8347274: Gatherers.mapConcurrent exhibits undesired behavior under variable delays, interruption, and finishing
  • e76cc44: 8347407: [BACKOUT] C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash)
  • 4a623a2: 8342468: Improve API documentation for java.lang.classfile.constantpool
  • ecdc322: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
  • da74fbd: 8347006: LoadRangeNode floats above array guard in arraycopy intrinsic
  • ... and 19 more: https://git.openjdk.org/jdk/compare/bed040191bda38726b8894a3e937138eb798027d...jdk24

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 15, 2025
@openjdk openjdk bot closed this Jan 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 15, 2025
@openjdk
Copy link

openjdk bot commented Jan 15, 2025

@TobiHartmann @MaxXSoft Pushed as commit f7858e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants