-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8346871: Improve robustness of java/util/zip/EntryCount64k.java test #22892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
|
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thank you Lance for the review. |
|
/integrate |
|
Going to push as commit 24c5ff7. |
Can I please get a review of this test-only change which improves the
test/jdk/java/util/zip/EntryCount64k.javatest code to allow for it to pass when the JVM logs any warning when launching an application throughjava -jar ...?The proposed change merely relaxes a check to allow for additional content to be present in the launched process' stdout. This doesn't change any of the original goals of the test.
The test failure was reproduced (on Linux) by launching the test through
jtregwith-javaoption:"-XX:+UseNUMA". With the proposed change in this PR, the test now passes when launched in that manner (and even without that option).Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22892/head:pull/22892$ git checkout pull/22892Update a local copy of the PR:
$ git checkout pull/22892$ git pull https://git.openjdk.org/jdk.git pull/22892/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22892View PR using the GUI difftool:
$ git pr show -t 22892Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22892.diff
Using Webrev
Link to Webrev Comment