Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346847: [s390x] minimal build failure #22895

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Dec 30, 2024

Hi all,

This pull request contains a backport of commit 807f6f7f from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 27 Dec 2024 and was reviewed by Thomas Stuefe.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346847: [s390x] minimal build failure (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22895/head:pull/22895
$ git checkout pull/22895

Update a local copy of the PR:
$ git checkout pull/22895
$ git pull https://git.openjdk.org/jdk.git pull/22895/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22895

View PR using the GUI difftool:
$ git pr show -t 22895

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22895.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 30, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 30, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346847: [s390x] minimal build failure

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 807f6f7fb868240cba5ba117c7059216f69a53f9 8346847: [s390x] minimal build failure Dec 30, 2024
@openjdk
Copy link

openjdk bot commented Dec 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 30, 2024
@openjdk
Copy link

openjdk bot commented Dec 30, 2024

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 30, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 30, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 30, 2024
@offamitkumar
Copy link
Member Author

Thanks for approval Christoph :)

/integrate

@openjdk
Copy link

openjdk bot commented Dec 31, 2024

Going to push as commit 4254e99.
Since your change was applied there have been 2 commits pushed to the jdk24 branch:

  • 05c3769: 8337111: Bad HTML checker for generated documentation
  • ab78b04: 8346667: Doccheck: warning about missing before

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 31, 2024
@openjdk openjdk bot closed this Dec 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 31, 2024
@openjdk
Copy link

openjdk bot commented Dec 31, 2024

@offamitkumar Pushed as commit 4254e99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants