Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM #22901

Closed
wants to merge 2 commits into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Jan 2, 2025

Hi, TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM, on riscv platform need to have rvv extension to run it.

Testing

  • Run TestVectorReinterpret.java tests on SOPHON SG2042 without rvv1.0 (fastdebug)
  • Run TestVectorReinterpret.java tests on Banana Pi BPI-F3 board (with RVV1.0) (fastdebug)
  • Run TestVectorReinterpret.java tests on aarch64 with neon
  • Run TestVectorReinterpret.java tests on Xeon(R) Platinum 8378A CPU

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22901/head:pull/22901
$ git checkout pull/22901

Update a local copy of the PR:
$ git checkout pull/22901
$ git pull https://git.openjdk.org/jdk.git pull/22901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22901

View PR using the GUI difftool:
$ git pr show -t 22901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22901.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2025

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 2, 2025

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM

Reviewed-by: fyang, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved
  • 84e6432: 8346288: WB_IsIntrinsicAvailable fails if called with wrong compilation level
  • a77ed30: 8336412: sun.net.www.MimeTable has a few unused methods
  • e769b53: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17
  • a87bc7e: 8345374: Ubsan: runtime error: division by zero

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2025
@openjdk
Copy link

openjdk bot commented Jan 2, 2025

@zifeihan The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jan 2, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2025

Webrevs

Comment on lines 42 to 43
* @requires (os.arch=="x86" | os.arch=="i386" | os.arch=="amd64" | os.arch=="x86_64" | os.arch=="aarch64" | os.arch == "ppc64" | os.arch == "ppc64le" | os.arch == "s390x") |
* (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be as next?:

 * @requires os.arch != "riscv64" | vm.cpu.features ~= ".*rvv.*"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be as next?:

 * @requires os.arch != "riscv64" | vm.cpu.features ~= ".*rvv.*"

Thanks for your review. it was very helpful and I have fixed it.

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2025
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@zifeihan
Copy link
Member Author

zifeihan commented Jan 6, 2025

Thanks all for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 6, 2025
@openjdk
Copy link

openjdk bot commented Jan 6, 2025

@zifeihan
Your change (at version 5d0c366) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 6, 2025

Going to push as commit e98f412.
Since your change was applied there have been 6 commits pushed to the master branch:

  • ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
  • 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved
  • 84e6432: 8346288: WB_IsIntrinsicAvailable fails if called with wrong compilation level
  • a77ed30: 8336412: sun.net.www.MimeTable has a few unused methods
  • e769b53: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17
  • a87bc7e: 8345374: Ubsan: runtime error: division by zero

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2025
@openjdk openjdk bot closed this Jan 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 6, 2025
@openjdk
Copy link

openjdk bot commented Jan 6, 2025

@RealFYang @zifeihan Pushed as commit e98f412.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the JDK-8346922 branch February 17, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants