-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM #22901
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @vnkozlov) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
* @requires (os.arch=="x86" | os.arch=="i386" | os.arch=="amd64" | os.arch=="x86_64" | os.arch=="aarch64" | os.arch == "ppc64" | os.arch == "ppc64le" | os.arch == "s390x") | | ||
* (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be as next?:
* @requires os.arch != "riscv64" | vm.cpu.features ~= ".*rvv.*"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be as next?:
* @requires os.arch != "riscv64" | vm.cpu.features ~= ".*rvv.*"
Thanks for your review. it was very helpful and I have fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Thanks all for the review. |
/sponsor |
Going to push as commit e98f412.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit e98f412. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM, on riscv platform need to have rvv extension to run it.
Testing
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22901/head:pull/22901
$ git checkout pull/22901
Update a local copy of the PR:
$ git checkout pull/22901
$ git pull https://git.openjdk.org/jdk.git pull/22901/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22901
View PR using the GUI difftool:
$ git pr show -t 22901
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22901.diff
Using Webrev
Link to Webrev Comment