8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements #22904

seanjmullan · 2025-01-02T14:41:48Z

Periodically, we review the security algorithm requirements to see if new algorithms should be added or existing ones should be removed. The requirements are intended to improve interoperability across different SE implementations by requiring a set of commonly used algorithms. The algorithms are not always based on the strength of the algorithm; the requirements are also based on how common the algorithms are, so some weaker algorithms are still on the list in order to support legacy use cases.

Add TLSv1.3 to the list of requirements. TLSv1.3 is the most secure protocol version and is in wide use. Add all cryptographic algorithms that are needed to implement the TLSv1.3 cipher suites and signature mechanisms defined by https://www.rfc-editor.org/rfc/rfc8446 as MUST or SHOULD requirements. Also add algorithms that are required by CNSA 1.0, which was added in JDK 19: https://bugs.openjdk.org/browse/JDK-8267319.

No required algorithms or protocols are being removed at this time.

See the CSR for the complete list of new requirements: https://bugs.openjdk.org/browse/JDK-8346684

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8346684 to be approved

Issues

JDK-8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements (Enhancement - P3)
JDK-8346684: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements (CSR)

Reviewers

Jamil Nimeh (@jnimeh - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22904/head:pull/22904
$ git checkout pull/22904

Update a local copy of the PR:
$ git checkout pull/22904
$ git pull https://git.openjdk.org/jdk.git pull/22904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22904

View PR using the GUI difftool:
$ git pr show -t 22904

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22904.diff

Using Webrev

Link to Webrev Comment

seanjmullan · 2025-01-02T14:41:58Z

/csr

bridgekeeper · 2025-01-02T14:42:36Z

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-01-02T14:43:34Z

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements

Reviewed-by: jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

1ef77cd: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory
72f1114: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters
cb9a98b: 8347141: Several javac tests compile with an unnecessary -Xlint:-path flag
f9b1133: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
9c72ded: 8346036: Unnecessary Hashtable usage in javax.swing.text.html.parser.Entity
3024a73: 8345782: Refining the cases that libjsig deprecation warning is issued
2801bc6: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE
ceae2b9: 8347121: Add missing @serial tags to module java.base
8c87ea2: 8346478: RISC-V: Refactor add/sub assembler routines
765b9e6: 8346706: RISC-V: Add available registers to hs_err
... and 69 more: https://git.openjdk.org/jdk/compare/a77ed30fcc3360cd16a11b1899f52f7e871df1df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-01-02T14:44:08Z

@seanjmullan an approved CSR request is already required for this pull request.

openjdk · 2025-01-02T14:44:45Z

@seanjmullan The following labels will be automatically applied to this pull request:

net
security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-01-02T14:48:11Z

Webrevs

jnimeh

These changes look good to me.

ecki · 2025-01-02T23:05:53Z

src/java.base/share/classes/java/security/KeyPairGenerator.java

 * <ul>
- * <li>{@code DiffieHellman} (1024, 2048, 4096)</li>
+ * <li>{@code DiffieHellman} (1024, 2048, 3072, 4096)</li>


Will there be a separate initiative to remove the 1024 from the requirements (or make clear that implementations are allowed to denn it by default policy).

I also wonder if more SHA3 should be added to the required algorithms.

The ticket Talks about tlsv1.3 and CNA 1.0, is the curve25519/chacha20 made mandatory due to TLS or just best practice?

Thanks for the comments.

As mentioned in the PR description, these requirements are not always based on the strength of the algorithm. We also want to support legacy use cases of algorithms that were commonly used for a long time. For 1024-bit keys, I referred to other standard bodies for guidance, for example NIST still allows verification of signatures signed with 1024 bit keys for legacy use cases. That said, 1024 bit keys will probably be a candidate to remove from the requirements in a future revision.

I considered adding SHA-3, but I wanted to focus on TLSv1.3 and CNSA 1.0 for this revision.

The curve25519/chacha20 requirements are based on the SHOULD requirements of https://www.rfc-editor.org/rfc/rfc8446#section-9.1.

…haCha20".

… Signature requirements.

jnimeh

Updates look good.

seanjmullan · 2025-01-09T17:33:07Z

/integrate

openjdk · 2025-01-09T17:34:21Z

Going to push as commit 3bfa952.
Since your change was applied there have been 79 commits pushed to the master branch:

1ef77cd: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory
72f1114: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters
cb9a98b: 8347141: Several javac tests compile with an unnecessary -Xlint:-path flag
f9b1133: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
9c72ded: 8346036: Unnecessary Hashtable usage in javax.swing.text.html.parser.Entity
3024a73: 8345782: Refining the cases that libjsig deprecation warning is issued
2801bc6: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE
ceae2b9: 8347121: Add missing @serial tags to module java.base
8c87ea2: 8346478: RISC-V: Refactor add/sub assembler routines
765b9e6: 8346706: RISC-V: Add available registers to hs_err
... and 69 more: https://git.openjdk.org/jdk/compare/a77ed30fcc3360cd16a11b1899f52f7e871df1df...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-09T17:34:27Z

@seanjmullan Pushed as commit 3bfa952.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

seanjmullan added 2 commits January 2, 2025 09:05

New requirements.

b38092d

Merge

823cbef

openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jan 2, 2025

openjdk bot added security security-dev@openjdk.org net net-dev@openjdk.org labels Jan 2, 2025

jnimeh approved these changes Jan 2, 2025

View reviewed changes

ecki reviewed Jan 2, 2025

View reviewed changes

AlgorithmParameters requirement should be "ChaCha20-Poly1305", not "C…

b622c99

…haCha20".

openjdk bot removed the csr Pull request needs approved CSR before integration label Jan 8, 2025

Fix typo in Cipher ChaCha20 requirement, and remove "curve" word from…

b508961

… Signature requirements.

jnimeh approved these changes Jan 9, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025

openjdk bot added the integrated Pull request has been integrated label Jan 9, 2025

openjdk bot closed this Jan 9, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements #22904

8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements #22904

seanjmullan commented Jan 2, 2025 •

edited by openjdk bot

Loading

seanjmullan commented Jan 2, 2025

bridgekeeper bot commented Jan 2, 2025

openjdk bot commented Jan 2, 2025 •

edited

Loading

openjdk bot commented Jan 2, 2025

openjdk bot commented Jan 2, 2025

mlbridge bot commented Jan 2, 2025 •

edited

Loading

jnimeh left a comment

ecki Jan 2, 2025

seanjmullan Jan 3, 2025

jnimeh left a comment

seanjmullan commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements #22904

8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements #22904

Conversation

seanjmullan commented Jan 2, 2025 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

seanjmullan commented Jan 2, 2025

bridgekeeper bot commented Jan 2, 2025

openjdk bot commented Jan 2, 2025 • edited Loading

openjdk bot commented Jan 2, 2025

openjdk bot commented Jan 2, 2025

mlbridge bot commented Jan 2, 2025 • edited Loading

Webrevs

jnimeh left a comment

Choose a reason for hiding this comment

ecki Jan 2, 2025

Choose a reason for hiding this comment

seanjmullan Jan 3, 2025

Choose a reason for hiding this comment

jnimeh left a comment

Choose a reason for hiding this comment

seanjmullan commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

seanjmullan commented Jan 2, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jan 2, 2025 •

edited

Loading

mlbridge bot commented Jan 2, 2025 •

edited

Loading