8342996: Enhance Attach API to support arbitrary length arguments - OSX

[alexmenkov]

The fix updates client side of OSX implementation to support Attach API v2.
Server side is shared with Linux and was updated by #22223.
The changes are identical to client-side changes for Linux from #22223.

Testing: tier1,tier2,tier3,tier4,hs-tier5-svc

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342996: Enhance Attach API to support arbitrary length arguments - OSX (Sub-task - P3)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22907/head:pull/22907
$ git checkout pull/22907

Update a local copy of the PR:
$ git checkout pull/22907
$ git pull https://git.openjdk.org/jdk.git pull/22907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22907

View PR using the GUI difftool:
$ git pr show -t 22907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22907.diff

Using Webrev

Link to Webrev Comment

[alexmenkov]

/label add serviceability

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342996: Enhance Attach API to support arbitrary length arguments - OSX

Reviewed-by: sspitsyn, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 137 new commits pushed to the master branch:

• d3a7ac2: 8346383: Cannot use DllMain in libdt_socket for static builds
• 13a1775: 8344146: Remove temporary font file tracking code.
• 61dc07c: 8346869: [AIX] Add regression test for handling 4 Byte aligned doubles in structures
• 13e1ea5: 8346038: [REDO] - [C1] LIR Operations with one input should be implemented as LIR_Op1
• 7c883c2: 8347605: Use spec tag to refer to IEEE 754 standard
• 4e0ffda: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk
• e0f2f4b: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• b0c131e: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025
• a7915bb: 8346468: SM cleanup of common test library
• f67b703: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
• ... and 127 more: https://git.openjdk.org/jdk/compare/84e6432bb73e35b32f12cdc0e1a172b7c973e618...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 00: Full (425877bf)

[sspitsyn]

This looks good.

[kevinjwalls]

Looks good to me. Will be good to have them all done. 8-)

[alexmenkov]

Thank you for the review Serguei and Kevin
/integrate

[openjdk]

Going to push as commit 0ae5c6b.
Since your change was applied there have been 139 commits pushed to the master branch:

• 91b63ca: 8345016: [ASAN] java.c reported ‘%s’ directive argument is null [-Werror=format-truncation=]
• 379d05b: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros
• d3a7ac2: 8346383: Cannot use DllMain in libdt_socket for static builds
• 13a1775: 8344146: Remove temporary font file tracking code.
• 61dc07c: 8346869: [AIX] Add regression test for handling 4 Byte aligned doubles in structures
• 13e1ea5: 8346038: [REDO] - [C1] LIR Operations with one input should be implemented as LIR_Op1
• 7c883c2: 8347605: Use spec tag to refer to IEEE 754 standard
• 4e0ffda: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk
• e0f2f4b: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• b0c131e: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025
• ... and 129 more: https://git.openjdk.org/jdk/compare/84e6432bb73e35b32f12cdc0e1a172b7c973e618...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 0ae5c6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.