-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8334644 : Automate javax/print/attribute/PageRangesException.java #22909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into |
@Renjithkannath This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @kumarabhi006, @azvegint) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@Renjithkannath The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for minor comments.
System.out.println("OKAY: IllegalArgumentException " + ie); | ||
} | ||
|
||
//test 4433096 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//test 4433096 | |
// test 4433096 |
For consistency.
@@ -0,0 +1,55 @@ | |||
/* | |||
* Copyright (c) 2001, 2024, Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright (c) 2001, 2024, Oracle and/or its affiliates. All rights reserved. | |
* Copyright (c) 2001, 2025, Oracle and/or its affiliates. All rights reserved. |
The year should be 2025 now.
Use JDK-8334644 as the bug id for this PR. I've closed JDK-8346846 as duplicate of JDK-8334644. |
/integrate |
@Renjithkannath |
/sponsor |
Going to push as commit 030149f.
Your commit was automatically rebased without conflicts. |
@azvegint @Renjithkannath Pushed as commit 030149f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi All,
I have updated the test and made it automation friendly. Please review and let me know your suggestions
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22909/head:pull/22909
$ git checkout pull/22909
Update a local copy of the PR:
$ git checkout pull/22909
$ git pull https://git.openjdk.org/jdk.git pull/22909/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22909
View PR using the GUI difftool:
$ git pr show -t 22909
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22909.diff
Using Webrev
Link to Webrev Comment