Skip to content

8334644 : Automate javax/print/attribute/PageRangesException.java #22909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Renjithkannath
Copy link
Contributor

@Renjithkannath Renjithkannath commented Jan 3, 2025

Hi All,

I have updated the test and made it automation friendly. Please review and let me know your suggestions


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334644: Automate javax/print/attribute/PageRangesException.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22909/head:pull/22909
$ git checkout pull/22909

Update a local copy of the PR:
$ git checkout pull/22909
$ git pull https://git.openjdk.org/jdk.git pull/22909/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22909

View PR using the GUI difftool:
$ git pr show -t 22909

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22909.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2025

👋 Welcome back rkannathpari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@Renjithkannath This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334644: Automate javax/print/attribute/PageRangesException.java

Reviewed-by: aivanov, abhiscxk, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • e5f0c19: 8345041: IGV: Free Placement Mode in IGV Layout
  • 8b22517: 8211851: (ch) java/nio/channels/AsynchronousSocketChannel/StressLoopback.java times out (aix)
  • 5e6cda4: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 3f7052e: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689
  • f119663: 8346573: Can't use custom default file system provider with custom system class loader
  • 379ac34: 8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
  • 0285020: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64
  • 0a81676: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer
  • 08debd3: 8346993: C2 SuperWord: refactor to make more vector nodes available in VectorNode::make
  • de02503: 8346832: runtime/CompressedOops/CompressedCPUSpecificClassSpaceReservation.java fails on RISC-V
  • ... and 17 more: https://git.openjdk.org/jdk/compare/84e6432bb73e35b32f12cdc0e1a172b7c973e618...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @kumarabhi006, @azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2025
@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@Renjithkannath The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 3, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2025

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for minor comments.

System.out.println("OKAY: IllegalArgumentException " + ie);
}

//test 4433096
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//test 4433096
// test 4433096

For consistency.

@@ -0,0 +1,55 @@
/*
* Copyright (c) 2001, 2024, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2001, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2001, 2025, Oracle and/or its affiliates. All rights reserved.

The year should be 2025 now.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2025
@aivanov-jdk
Copy link
Member

Use JDK-8334644 as the bug id for this PR. I've closed JDK-8346846 as duplicate of JDK-8334644.

@Renjithkannath Renjithkannath changed the title 8346846 : Open source PageRangesException.java test 8334644 : Automate javax/print/attribute/PageRangesException.java Jan 6, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 6, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2025
@Renjithkannath
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 7, 2025
@openjdk
Copy link

openjdk bot commented Jan 7, 2025

@Renjithkannath
Your change (at version 9ef119e) is now ready to be sponsored by a Committer.

@azvegint
Copy link
Member

azvegint commented Jan 7, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 7, 2025

Going to push as commit 030149f.
Since your change was applied there have been 30 commits pushed to the master branch:

  • c8a9dd3: 8346609: Improve MemorySegment.toString
  • 4d8fb80: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError
  • cf3e48e: 8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache
  • e5f0c19: 8345041: IGV: Free Placement Mode in IGV Layout
  • 8b22517: 8211851: (ch) java/nio/channels/AsynchronousSocketChannel/StressLoopback.java times out (aix)
  • 5e6cda4: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 3f7052e: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689
  • f119663: 8346573: Can't use custom default file system provider with custom system class loader
  • 379ac34: 8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
  • 0285020: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64
  • ... and 20 more: https://git.openjdk.org/jdk/compare/84e6432bb73e35b32f12cdc0e1a172b7c973e618...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2025
@openjdk openjdk bot closed this Jan 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 7, 2025
@openjdk
Copy link

openjdk bot commented Jan 7, 2025

@azvegint @Renjithkannath Pushed as commit 030149f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Renjithkannath Renjithkannath deleted the 8346846-v1 branch April 8, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants