Skip to content

Conversation

@asotona
Copy link
Member

@asotona asotona commented Jan 3, 2025

This PR removes obsolete java.base exports of jdk.internal.objectweb.asm packages to jdk.jfr module.

Please review.

Thanks,
Adam


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

  • JDK-8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22912/head:pull/22912
$ git checkout pull/22912

Update a local copy of the PR:
$ git checkout pull/22912
$ git pull https://git.openjdk.org/jdk.git pull/22912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22912

View PR using the GUI difftool:
$ git pr show -t 22912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22912.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2025

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages

Reviewed-by: liach, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
  • f1d85ab: 8346773: Fix unmatched brackets in some misc files
  • 9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
  • e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
  • ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
  • 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2025
@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@asotona The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 3, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2025

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; waiting for a JFR reviewer.

/label add hotspot-jfr
/reviewers 2 reviewer

@openjdk openjdk bot added ready Pull request is ready to be integrated hotspot-jfr hotspot-jfr-dev@openjdk.org labels Jan 3, 2025
@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@liach
The hotspot-jfr label was successfully added.

@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@liach
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 3, 2025
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup, these qualified exports should probably have been removed in JDK 22 when the instrumentation moved to the class file API. I assume you'll bump the copyright date before integrating.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 6, 2025
@asotona asotona requested a review from liach January 6, 2025 13:36
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2025
@asotona
Copy link
Member Author

asotona commented Jan 6, 2025

Thank you for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 6, 2025

Going to push as commit e0695e0.
Since your change was applied there have been 6 commits pushed to the master branch:

  • dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
  • f1d85ab: 8346773: Fix unmatched brackets in some misc files
  • 9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
  • e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
  • ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
  • 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2025
@openjdk openjdk bot closed this Jan 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2025
@openjdk
Copy link

openjdk bot commented Jan 6, 2025

@asotona Pushed as commit e0695e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants