-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages #22912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back asotona! A progress list of the required criteria for merging this PR into |
|
@asotona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
liach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; waiting for a JFR reviewer.
/label add hotspot-jfr
/reviewers 2 reviewer
|
@liach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup, these qualified exports should probably have been removed in JDK 22 when the instrumentation moved to the class file API. I assume you'll bump the copyright date before integrating.
|
Thank you for the reviews. /integrate |
|
Going to push as commit e0695e0.
Your commit was automatically rebased without conflicts. |
This PR removes obsolete java.base exports of jdk.internal.objectweb.asm packages to jdk.jfr module.
Please review.
Thanks,
Adam
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22912/head:pull/22912$ git checkout pull/22912Update a local copy of the PR:
$ git checkout pull/22912$ git pull https://git.openjdk.org/jdk.git pull/22912/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22912View PR using the GUI difftool:
$ git pr show -t 22912Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22912.diff
Using Webrev
Link to Webrev Comment