Skip to content

Conversation

@asotona
Copy link
Member

@asotona asotona commented Jan 3, 2025

This patch removes obsolete ASM-based transformations from Class-File API tests.

Please review.

Thanks,
Adam


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346983: Remove ASM-based transforms from Class-File API tests (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22913/head:pull/22913
$ git checkout pull/22913

Update a local copy of the PR:
$ git checkout pull/22913
$ git pull https://git.openjdk.org/jdk.git pull/22913/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22913

View PR using the GUI difftool:
$ git pr show -t 22913

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22913.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2025

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346983: Remove ASM-based transforms from Class-File API tests

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
  • f1d85ab: 8346773: Fix unmatched brackets in some misc files
  • 9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
  • e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
  • ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
  • 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2025
@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@asotona To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@asotona
Copy link
Member Author

asotona commented Jan 3, 2025

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 3, 2025
@openjdk
Copy link

openjdk bot commented Jan 3, 2025

@asotona
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 3, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 6, 2025
@asotona asotona requested a review from liach January 6, 2025 13:36
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2025
@asotona
Copy link
Member Author

asotona commented Jan 6, 2025

Thank you for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 6, 2025

Going to push as commit c027f2e.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e0695e0: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
  • dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
  • f1d85ab: 8346773: Fix unmatched brackets in some misc files
  • 9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
  • e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
  • ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
  • 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2025
@openjdk openjdk bot closed this Jan 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2025
@openjdk
Copy link

openjdk bot commented Jan 6, 2025

@asotona Pushed as commit c027f2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants