-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8346983: Remove ASM-based transforms from Class-File API tests #22913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back asotona! A progress list of the required criteria for merging this PR into |
|
@asotona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@asotona To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label core-libs |
|
@asotona |
Webrevs
|
|
Thank you for the review. /integrate |
|
Going to push as commit c027f2e.
Your commit was automatically rebased without conflicts. |
This patch removes obsolete ASM-based transformations from Class-File API tests.
Please review.
Thanks,
Adam
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22913/head:pull/22913$ git checkout pull/22913Update a local copy of the PR:
$ git checkout pull/22913$ git pull https://git.openjdk.org/jdk.git pull/22913/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22913View PR using the GUI difftool:
$ git pr show -t 22913Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22913.diff
Using Webrev
Link to Webrev Comment