8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API

[asotona]

This patch converts the remaining test/jdk/com/sun/jdi/ClassUnloadEventTest.java from ASM to Class-File API.

Please review.

Thanks,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API (Sub-task - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22915/head:pull/22915
$ git checkout pull/22915

Update a local copy of the PR:
$ git checkout pull/22915
$ git pull https://git.openjdk.org/jdk.git pull/22915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22915

View PR using the GUI difftool:
$ git pr show -t 22915

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22915.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346985: Convert test/jdk/com/sun/jdi/ClassUnloadEventTest.java to Class-File API

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
• f1d85ab: 8346773: Fix unmatched brackets in some misc files
• 9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
• e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
• ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
• 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9e8471d8)
• 00: Full (bc0b9dfa)

[liach]

This anticipates an internal name but gets a binary name passed. This works in the old code accidentally because its classes were in the unnamed package. The port fixes this bug.

[asotona]

Thank you for the review.

/integrate

[openjdk]

Going to push as commit ccf3d57.
Since your change was applied there have been 9 commits pushed to the master branch:

• 594e519: 8346984: Remove ASM-based benchmarks from Class-File API benchmarks
• c027f2e: 8346983: Remove ASM-based transforms from Class-File API tests
• e0695e0: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
• dfaa891: 8346569: Shenandoah: Worker initializes ShenandoahThreadLocalData twice results in memory leak
• f1d85ab: 8346773: Fix unmatched brackets in some misc files
• 9393897: 8346260: Test "javax/swing/JOptionPane/bug4174551.java" failed because the font size of message "Hi 24" is not set to 24 in Nimbus LookAndFeel
• e98f412: 8346922: TestVectorReinterpret.java fails without the rvv extension on RISCV fastdebug VM
• ca5390c: 8346924: TestVectorizationNegativeScale.java fails without the rvv extension on RISCV fastdebug VM
• 07c9f71: 8346921: Remove unused arg in markWord::must_be_preserved

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit ccf3d57.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.