8329549: Remove FORMAT64_MODIFIER

[coleenp]

This change removes FORMAT64_MODIFIER but adds another INT64_FORMAT_X_0_ macro to specify not having leading "0x" in the output. Suggestions for better macro name welcome.
GHA tested.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8329549: Remove FORMAT64_MODIFIER (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22918/head:pull/22918
$ git checkout pull/22918

Update a local copy of the PR:
$ git checkout pull/22918
$ git pull https://git.openjdk.org/jdk.git pull/22918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22918

View PR using the GUI difftool:
$ git pr show -t 22918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22918.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329549: Remove FORMAT64_MODIFIER

Reviewed-by: dholmes, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• 098afc8: 8339113: AccessFlags can be u2 in metadata
• e413fc6: 8347127: CTW fails to build after JDK-8334733
• 9702acc: 8175709: DateTimeFormatterBuilder.appendZoneId() has misleading JavaDoc
• 030149f: 8334644: Automate javax/print/attribute/PageRangesException.java
• c8a9dd3: 8346609: Improve MemorySegment.toString
• 4d8fb80: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError
• cf3e48e: 8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache
• e5f0c19: 8345041: IGV: Free Placement Mode in IGV Layout
• 8b22517: 8211851: (ch) java/nio/channels/AsynchronousSocketChannel/StressLoopback.java times out (aix)
• 5e6cda4: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
• ... and 23 more: https://git.openjdk.org/jdk/compare/07c9f7138affdf0d42ecdc30adcb854515569985...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (6ac66379)
• 01: Full - Incremental (f2223d2c)
• 00: Full (c93c939b)

[dholmes-ora]

Why the trailing underscore?

The name doesn't make sense to me given we have UINT64_FORMAT_X_0 and the only difference here is the leading 0x which doesn't really have anything to do with signed-ness. Maybe RAW_UINT64_FORMAT_X_0 to indicate the dropped 0x prefix ?

[coleenp]

Thanks for the suggestion. All the macros start with UINT64_FORMAT though. How about UINT64_FORMAT_RAW_X_0 ? or UINT64_FORMAT_X_0_RAW ? Still not great.

[dholmes-ora]

UINT64_FORMAT_RAW_X_0 is not terrible. :)

[dholmes-ora]

To be honest though I don't know why we want hexadecimal output without the leading 0x ...

[stefank]

The _X infix is meant to indicate 0x. I think UINT64_FORMAT_0 is what you are looking for.

[coleenp]

I thought X was hexadecimal. That's a lot better. Thanks.

[dholmes-ora]

// Guide to the suffixes used in the format specifiers for integers:
//        - print the decimal value:                   745565
//  _X    - print as hexadecimal, without leading 0s: 0x12345
//  _X_0  - print as hexadecimal, with leading 0s: 0x00012345

It wasn't obvious to me that the _X meant hexadecimal-with-0x-prefix versus simply hexadecimal. But I have no issue with always doing 0x :)

[stefank]

Hmm. You are right. I read too much into the comment (that I wrote some time ago :) )

[dholmes-ora]

That looks good to me. Thanks

[coleenp]

Thanks for reviewing, David.

[kimbarrett]

Looks good.

[coleenp]

Thanks for the review Kim.

[coleenp]

/integrate

[openjdk]

Going to push as commit ddb5881.
Since your change was applied there have been 33 commits pushed to the master branch:

• 098afc8: 8339113: AccessFlags can be u2 in metadata
• e413fc6: 8347127: CTW fails to build after JDK-8334733
• 9702acc: 8175709: DateTimeFormatterBuilder.appendZoneId() has misleading JavaDoc
• 030149f: 8334644: Automate javax/print/attribute/PageRangesException.java
• c8a9dd3: 8346609: Improve MemorySegment.toString
• 4d8fb80: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError
• cf3e48e: 8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache
• e5f0c19: 8345041: IGV: Free Placement Mode in IGV Layout
• 8b22517: 8211851: (ch) java/nio/channels/AsynchronousSocketChannel/StressLoopback.java times out (aix)
• 5e6cda4: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
• ... and 23 more: https://git.openjdk.org/jdk/compare/07c9f7138affdf0d42ecdc30adcb854515569985...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit ddb5881.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.