-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError #22923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…va.lang.NoClassDefFoundError: jdk/incubator/vector/FloatVector
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
/issue JDK-8347038 |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@sendaoYan This issue is referenced in the PR title - it will now be updated. |
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Thanks for the review. /integrate |
Going to push as commit 4d8fb80.
Your commit was automatically rebased without conflicts. |
@sendaoYan Pushed as commit 4d8fb80. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk21u-dev |
@sendaoYan the backport was successfully created on the branch backport-sendaoYan-4d8fb807-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:
|
/backport jdk24u |
@sendaoYan the backport was successfully created on the branch backport-sendaoYan-4d8fb807-master in my personal fork of openjdk/jdk24u. To create a pull request with this backport targeting openjdk/jdk24u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk24u:
|
Hi all,
This PR add JVM option
jvmArgs={"--add-modules=jdk.incubator.vector"}
for test/micro/org/openjdk/bench/jdk/incubator/vector/SpiltReplicate.java, to fix test bug which cause jmh test fails 'java.lang.NoClassDefFoundError: jdk/incubator/vector/FloatVector'. Change has been verified locally, test-fix only, no risk.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22923/head:pull/22923
$ git checkout pull/22923
Update a local copy of the PR:
$ git checkout pull/22923
$ git pull https://git.openjdk.org/jdk.git pull/22923/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22923
View PR using the GUI difftool:
$ git pr show -t 22923
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22923.diff
Using Webrev
Link to Webrev Comment