Skip to content

8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError #22923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 6, 2025

Hi all,
This PR add JVM option jvmArgs={"--add-modules=jdk.incubator.vector"} for test/micro/org/openjdk/bench/jdk/incubator/vector/SpiltReplicate.java, to fix test bug which cause jmh test fails 'java.lang.NoClassDefFoundError: jdk/incubator/vector/FloatVector'. Change has been verified locally, test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22923/head:pull/22923
$ git checkout pull/22923

Update a local copy of the PR:
$ git checkout pull/22923
$ git pull https://git.openjdk.org/jdk.git pull/22923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22923

View PR using the GUI difftool:
$ git pr show -t 22923

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22923.diff

Using Webrev

Link to Webrev Comment

…va.lang.NoClassDefFoundError: jdk/incubator/vector/FloatVector
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sendaoYan
Copy link
Member Author

/issue JDK-8347038

@sendaoYan sendaoYan changed the title 8347038: [JMH] jdk.incubator.vector.SpiltReplicate.testFloat fails java.lang.NoClassDefFoundError: jdk/incubator/vector/FloatVector 8347038: [JMH] jdk.incubator.vector.SpiltReplicate.testFloat fails NoClassDefFoundError Jan 6, 2025
@openjdk
Copy link

openjdk bot commented Jan 6, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2025
@openjdk
Copy link

openjdk bot commented Jan 6, 2025

@sendaoYan This issue is referenced in the PR title - it will now be updated.

@openjdk
Copy link

openjdk bot commented Jan 6, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 6, 2025
@sendaoYan sendaoYan changed the title 8347038: [JMH] jdk.incubator.vector.SpiltReplicate.testFloat fails NoClassDefFoundError 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError Jan 6, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2025
@sendaoYan
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 7, 2025

Going to push as commit 4d8fb80.
Since your change was applied there have been 23 commits pushed to the master branch:

  • cf3e48e: 8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache
  • e5f0c19: 8345041: IGV: Free Placement Mode in IGV Layout
  • 8b22517: 8211851: (ch) java/nio/channels/AsynchronousSocketChannel/StressLoopback.java times out (aix)
  • 5e6cda4: 8347000: Bug in com/sun/net/httpserver/bugs/B6361557.java test
  • 3f7052e: 8346868: RISC-V: compiler/sharedstubs tests fail after JDK-8332689
  • f119663: 8346573: Can't use custom default file system provider with custom system class loader
  • 379ac34: 8346838: RISC-V: runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crash with debug VMs
  • 0285020: 8345676: [ubsan] ProcessImpl_md.c:561:40: runtime error: applying zero offset to null pointer on macOS aarch64
  • 0a81676: 8346881: [ubsan] logSelection.cpp:154:24 / logSelectionList.cpp:72:94 : runtime error: applying non-zero offset 1 to null pointer
  • 08debd3: 8346993: C2 SuperWord: refactor to make more vector nodes available in VectorNode::make
  • ... and 13 more: https://git.openjdk.org/jdk/compare/f1d85ab3e61f923b4e120cf30e16109e04505b53...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2025
@openjdk openjdk bot closed this Jan 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 7, 2025
@openjdk
Copy link

openjdk bot commented Jan 7, 2025

@sendaoYan Pushed as commit 4d8fb80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8347038 branch January 7, 2025 15:10
@sendaoYan
Copy link
Member Author

/backport jdk21u-dev

@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@sendaoYan the backport was successfully created on the branch backport-sendaoYan-4d8fb807-master in my personal fork of openjdk/jdk21u-dev. To create a pull request with this backport targeting openjdk/jdk21u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4d8fb807 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 7 Jan 2025 and was reviewed by Paul Sandoz.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u-dev:

$ git fetch https://github.com/openjdk-bots/jdk21u-dev.git backport-sendaoYan-4d8fb807-master:backport-sendaoYan-4d8fb807-master
$ git checkout backport-sendaoYan-4d8fb807-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u-dev.git backport-sendaoYan-4d8fb807-master

@sendaoYan
Copy link
Member Author

/backport jdk24u

@openjdk
Copy link

openjdk bot commented Feb 5, 2025

@sendaoYan the backport was successfully created on the branch backport-sendaoYan-4d8fb807-master in my personal fork of openjdk/jdk24u. To create a pull request with this backport targeting openjdk/jdk24u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4d8fb807 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 7 Jan 2025 and was reviewed by Paul Sandoz.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk24u:

$ git fetch https://github.com/openjdk-bots/jdk24u.git backport-sendaoYan-4d8fb807-master:backport-sendaoYan-4d8fb807-master
$ git checkout backport-sendaoYan-4d8fb807-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk24u.git backport-sendaoYan-4d8fb807-master

⚠️ @sendaoYan You are not yet a collaborator in my fork openjdk-bots/jdk24u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants