Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260522: Clean up warnings in hotspot JTReg runtime tests #2293

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jan 28, 2021

Please review this fix to clean up some of the warnings generated when running hotspot/jtreg/runtime tests. This fix cleans up warnings such as:
warning: [removal] Integer(int) in Integer has been deprecated and marked for removal
warning: Main is internal proprietary API and may be removed in a future release
warning: Option FlightRecorder was deprecated in version 13.0 ...

The fix does not clean up warnings such as the following. They should probably best be cleaned up when the deprecated items are actually removed:
warning: [removal] suspend() in Thread has been deprecated and marked for removal
warning: [removal] resume() in Thread has been deprecated and marked for removal
warning: [removal] defineAnonymousClass(Class<?>,byte[],Object[]) in Unsafe has been deprecated ...
warning: the use of signal() and sigset() for signal chaining was deprecated in version 16.0

The fix was tested by running Mach5 hs-tiers 1-3 and by running tests locally and then looking for warnings in the resulting .jtr files.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260522: Clean up warnings in hotspot JTReg runtime tests

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2293/head:pull/2293
$ git checkout pull/2293

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@hseigel The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2021

Webrevs

Copy link
Member

@lfoltan lfoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Lois

@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260522: Clean up warnings in hotspot JTReg runtime tests

Reviewed-by: lfoltan, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 02d586e: 8259398: Super word not applied to a loop with byteArrayViewVarHandle
  • 80760a3: 8260669: Missing quotes in fixpath.sh
  • c0cde7d: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues
  • aec0377: 8257498: Remove useless skeleton predicates
  • ab727f0: 8260591: Shenandoah: improve parallelism for concurrent thread root scans
  • cf94208: 8259395: Patching automatic module with additional packages re-creates module without "requires java.base"
  • 039affc: 8260577: Unused code in AbstractCompiler after Shark compiler removal
  • 8a9004d: 8260574: Remove parallel constructs in GenCollectedHeap::process_roots
  • 0da9cad: 8260501: [Vector API] Improve register usage for shift operations on x86
  • a61ff87: 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/bbbfaa58c095c8adbd532e09ec239aa6cd52e3df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2021
Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hseigel
Copy link
Member Author

hseigel commented Feb 1, 2021

Thanks Lois and Coleen, for the reviews!

/integrate

@openjdk openjdk bot closed this Feb 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@hseigel Since your change was applied there have been 35 commits pushed to the master branch:

  • 02d586e: 8259398: Super word not applied to a loop with byteArrayViewVarHandle
  • 80760a3: 8260669: Missing quotes in fixpath.sh
  • c0cde7d: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues
  • aec0377: 8257498: Remove useless skeleton predicates
  • ab727f0: 8260591: Shenandoah: improve parallelism for concurrent thread root scans
  • cf94208: 8259395: Patching automatic module with additional packages re-creates module without "requires java.base"
  • 039affc: 8260577: Unused code in AbstractCompiler after Shark compiler removal
  • 8a9004d: 8260574: Remove parallel constructs in GenCollectedHeap::process_roots
  • 0da9cad: 8260501: [Vector API] Improve register usage for shift operations on x86
  • a61ff87: 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/bbbfaa58c095c8adbd532e09ec239aa6cd52e3df...master

Your commit was automatically rebased without conflicts.

Pushed as commit 181d63f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants