8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests #22939

rsunderbabu · 2025-01-07T07:58:18Z

Trivial logging message change.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests (Bug - P4)

Reviewers

David Holmes (@dholmes-ora - Reviewer)
Serguei Spitsyn (@sspitsyn - Reviewer)
Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22939/head:pull/22939
$ git checkout pull/22939

Update a local copy of the PR:
$ git checkout pull/22939
$ git pull https://git.openjdk.org/jdk.git pull/22939/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22939

View PR using the GUI difftool:
$ git pr show -t 22939

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22939.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-01-07T07:59:12Z

👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

rsunderbabu · 2025-01-07T07:59:50Z

Sanity testing done.

openjdk · 2025-01-07T07:59:50Z

@rsunderbabu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests

Reviewed-by: dholmes, sspitsyn, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

a46ae70: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
97dd06c: 8347299: Add annotations to test cases in LicenseTest
0a35ebf: 8347297: Skip the RuntimeImageSymbolicLinksTest test on Windows when it is executed outside of the jtreg
b3e8736: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
1ade96b: 8347042: Remove an extra parenthesis in macro definition in jfrTraceIdMacros.hpp
db7fa6a: 8347289: HKDF delayed provider selection failed with non-extractable PRK
0a5ef82: 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException
ea49537: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller
2e00816: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025
88fa3b2: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off
... and 34 more: https://git.openjdk.org/jdk/compare/08debd335e9160d20b87e06a2e83ddedd5f473b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @sspitsyn, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-01-07T08:00:33Z

@rsunderbabu The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-01-07T08:04:10Z

Webrevs

01: Full - Incremental (28c1b8ea)
00: Full (69071c5e)

dholmes-ora · 2025-01-08T05:48:42Z

test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2007, 2020, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2007, 2024, Oracle and/or its affiliates. All rights reserved.


Suggested change

* Copyright (c) 2007, 2024, Oracle and/or its affiliates. All rights reserved.

* Copyright (c) 2007, 2025, Oracle and/or its affiliates. All rights reserved.

subconsciously still in vacation, I guess. 😄

dholmes-ora · 2025-01-08T05:51:42Z

test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001.java

@@ -62,7 +62,7 @@ public static int run(String args[], PrintStream out) {
                makeThread();
            }

-            System.out.println("Can't reproduce OOME due to a limit on iterations/execution time. Test was useless."
+            System.out.println("Can't reproduce OOME due to a limit on iterations/execution time. resexhausted001 Test was useless."


Suggested change

System.out.println("Can't reproduce OOME due to a limit on iterations/execution time. resexhausted001 Test was useless."

System.out.println("Test resexhausted001: Can't reproduce OOME due to a limit on iterations/execution time. Test was useless."

This format reads somewhat better to me.

sspitsyn

It looks okay with the suggestion from David.

dholmes-ora

Looks good. Thanks

rsunderbabu · 2025-01-09T06:17:15Z

/integrate

openjdk · 2025-01-09T06:17:48Z

@rsunderbabu
Your change (at version 28c1b8e) is now ready to be sponsored by a Committer.

dholmes-ora · 2025-01-09T07:49:57Z

/sponsor

openjdk · 2025-01-09T07:50:45Z

Going to push as commit 33f9be8.
Since your change was applied there have been 45 commits pushed to the master branch:

8eddf67: 8346887: DrawFocusRect() may cause an assertion failure
a46ae70: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
97dd06c: 8347299: Add annotations to test cases in LicenseTest
0a35ebf: 8347297: Skip the RuntimeImageSymbolicLinksTest test on Windows when it is executed outside of the jtreg
b3e8736: 8347296: WinInstallerUiTest fails in local test runs if the path to test work directory is longer that regular
1ade96b: 8347042: Remove an extra parenthesis in macro definition in jfrTraceIdMacros.hpp
db7fa6a: 8347289: HKDF delayed provider selection failed with non-extractable PRK
0a5ef82: 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException
ea49537: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller
2e00816: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025
... and 35 more: https://git.openjdk.org/jdk/compare/08debd335e9160d20b87e06a2e83ddedd5f473b8...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-09T07:50:54Z

@dholmes-ora @rsunderbabu Pushed as commit 33f9be8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label Jan 7, 2025

openjdk bot added the serviceability serviceability-dev@openjdk.org label Jan 7, 2025

trivial logging change

69071c5

dholmes-ora suggested changes Jan 8, 2025

View reviewed changes

incorporated review comments

28c1b8e

sspitsyn approved these changes Jan 8, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2025

lmesnik approved these changes Jan 9, 2025

View reviewed changes

dholmes-ora approved these changes Jan 9, 2025

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2025

openjdk bot added the integrated Pull request has been integrated label Jan 9, 2025

openjdk bot closed this Jan 9, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2025

rsunderbabu deleted the 8347083 branch January 9, 2025 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests #22939

8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests #22939

rsunderbabu commented Jan 7, 2025 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 7, 2025

rsunderbabu commented Jan 7, 2025

openjdk bot commented Jan 7, 2025 •

edited

Loading

openjdk bot commented Jan 7, 2025

mlbridge bot commented Jan 7, 2025 •

edited

Loading

dholmes-ora Jan 8, 2025

rsunderbabu Jan 8, 2025

dholmes-ora Jan 8, 2025

sspitsyn left a comment

dholmes-ora left a comment

rsunderbabu commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

dholmes-ora commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

	* Copyright (c) 2007, 2024, Oracle and/or its affiliates. All rights reserved.
	* Copyright (c) 2007, 2025, Oracle and/or its affiliates. All rights reserved.

	System.out.println("Can't reproduce OOME due to a limit on iterations/execution time. resexhausted001 Test was useless."
	System.out.println("Test resexhausted001: Can't reproduce OOME due to a limit on iterations/execution time. Test was useless."

8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests #22939

8347083: Incomplete logging in nsk/jvmti/ResourceExhausted/resexhausted00* tests #22939

Conversation

rsunderbabu commented Jan 7, 2025 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 7, 2025

rsunderbabu commented Jan 7, 2025

openjdk bot commented Jan 7, 2025 • edited Loading

openjdk bot commented Jan 7, 2025

mlbridge bot commented Jan 7, 2025 • edited Loading

Webrevs

dholmes-ora Jan 8, 2025

Choose a reason for hiding this comment

rsunderbabu Jan 8, 2025

Choose a reason for hiding this comment

dholmes-ora Jan 8, 2025

Choose a reason for hiding this comment

sspitsyn left a comment

Choose a reason for hiding this comment

dholmes-ora left a comment

Choose a reason for hiding this comment

rsunderbabu commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

dholmes-ora commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

openjdk bot commented Jan 9, 2025

rsunderbabu commented Jan 7, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jan 7, 2025 •

edited

Loading

mlbridge bot commented Jan 7, 2025 •

edited

Loading