8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache

[sendaoYan]

Hi all,

This pull request contains a backport of commit cf3e48e7 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 7 Jan 2025 and was reviewed by Vladimir Kozlov.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache (Bug - P4)

Reviewers

• Emanuel Peter (@eme64 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22950/head:pull/22950
$ git checkout pull/22950

Update a local copy of the PR:
$ git checkout pull/22950
$ git pull https://git.openjdk.org/jdk.git pull/22950/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22950

View PR using the GUI difftool:
$ git pr show -t 22950

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22950.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346965: Multiple compiler/ciReplay test fails with -XX:+SegmentedCodeCache

Reviewed-by: epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7ba358df)

[eme64]

@sendaoYan the Affected version of JDK-8346965 only lists JDK25.
Since you are backporting to JDK24, this must be incomplete... Can you add all affected versions and link the change that caused the issue?

[sendaoYan]

@sendaoYan the Affected version of JDK-8346965 only lists JDK25. Since you are backporting to JDK24, this must be incomplete... Can you add all affected versions and link the change that caused the issue?

Sorry, the all affected versions has been updated. And the caused link has been added,

[eme64]

@sendaoYan But the likely cause JDK-8311248 was integrated in JDK23, so should that version not also be in the affected list?

[eme64]

Backport looks good.

[sendaoYan]

@sendaoYan But the likely cause JDK-8311248 was integrated in JDK23, so should that version not also be in the affected list?

Thanks, the '23' has been added to the affected list.

[sendaoYan]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit c3b5208.
Since your change was applied there has been 1 commit pushed to the jdk24 branch:

• 860b30d: 8347047: Cleanup action passed to MemorySegment::reinterpret keeps old segment alive

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit c3b5208.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.