-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347148: [BACKOUT] AccessFlags can be u2 in metadata #22959
Conversation
This reverts commit 098afc8.
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@dholmes-ora The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good plus urgent. Thanks for doing this, David.
Thanks for the review @coleenp ! Just waiting tier1 sanity to complete |
/integrate |
Going to push as commit 021c476. |
@dholmes-ora Pushed as commit 021c476. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Revert "8339113: AccessFlags can be u2 in metadata"
This reverts commit 098afc8.
The integration of the original change needs to be coordinated with a change to Graal so backing out till that is ready.
Thanks
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22959/head:pull/22959
$ git checkout pull/22959
Update a local copy of the PR:
$ git checkout pull/22959
$ git pull https://git.openjdk.org/jdk.git pull/22959/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22959
View PR using the GUI difftool:
$ git pr show -t 22959
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22959.diff
Using Webrev
Link to Webrev Comment