-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level #22965
8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level #22965
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Thank you @tschatzl! I think I need another Review to merge this. Thanks! |
Thanks! /integrate |
Going to push as commit 1a0fe49.
Your commit was automatically rebased without conflicts. |
For Epsilon, we have added
log_warning
messages when heap size and AlwaysPreTouch configuration is not great with JDK-8232051. Unfortunately, this means we print this warning all the time, even though users might not actually run into problems there, or when users tried to implement these suggestions and still decided to run against them.I think we want to emit the suggestions in the normal GC log instead, so they are not printed all the time. Additionally, I moved the printing at the end of init logger, so it does not come in the middle of
gc,init
block.Output before:
Output after:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22965/head:pull/22965
$ git checkout pull/22965
Update a local copy of the PR:
$ git checkout pull/22965
$ git pull https://git.openjdk.org/jdk.git pull/22965/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22965
View PR using the GUI difftool:
$ git pr show -t 22965
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22965.diff
Using Webrev
Link to Webrev Comment