8347147: [REDO] AccessFlags can be u2 in metadata

[coleenp]

This is the same change that I pushed as commit 098afc8 but now coordinated with @mur47x111 for the graal changes.

A tier1 sanity test complete.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347147: [REDO] AccessFlags can be u2 in metadata (Enhancement - P4)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Yudi Zheng (@mur47x111 - Committer)

Contributors

• Amit Kumar <amitkumar@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22968/head:pull/22968
$ git checkout pull/22968

Update a local copy of the PR:
$ git checkout pull/22968
$ git pull https://git.openjdk.org/jdk.git pull/22968/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22968

View PR using the GUI difftool:
$ git pr show -t 22968

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22968.diff

Using Webrev

Link to Webrev Comment

[coleenp]

/contributor add @offamitkumar

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347147: [REDO] AccessFlags can be u2 in metadata

Co-authored-by: Amit Kumar <amitkumar@openjdk.org>
Reviewed-by: vlivanov, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• a641932: 8346310: Duplicate !HAS_PENDING_EXCEPTION check in DynamicArchive::dump_at_exit
• 49ee4df: 8166983: Remove old/legacy unused tzdata files
• 3fe0818: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
• 55bcf4c: 8346047: JFR: Incorrect percentile value in 'jfr view'
• ae3fc46: 8345580: Remove const from Node::_idx which is modified
• 4d18e5a: 8346872: tools/jpackage/windows/WinLongPathTest.java fails
• 92ad8a1: 8346052: JFR: Incorrect average value in 'jfr view'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp
Contributor Amit Kumar <amitkumar@openjdk.org> successfully added.

[openjdk]

@coleenp The following labels will be automatically applied to this pull request:

• graal
• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (71419187)
• 01: Full - Incremental (9b2abf9c)
• 00: Full (71419187)

[coleenp]

PR for original review here: #22246

[iwanowww]

Reviewed.

[openjdk]

@coleenp Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[coleenp]

Thank you for the re-review Vladimir and Yudi.
/integrate

[openjdk]

Going to push as commit 6ee2bd2.
Since your change was applied there have been 7 commits pushed to the master branch:

• a641932: 8346310: Duplicate !HAS_PENDING_EXCEPTION check in DynamicArchive::dump_at_exit
• 49ee4df: 8166983: Remove old/legacy unused tzdata files
• 3fe0818: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
• 55bcf4c: 8346047: JFR: Incorrect percentile value in 'jfr view'
• ae3fc46: 8345580: Remove const from Node::_idx which is modified
• 4d18e5a: 8346872: tools/jpackage/windows/WinLongPathTest.java fails
• 92ad8a1: 8346052: JFR: Incorrect average value in 'jfr view'

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 6ee2bd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.