Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2) #2299

Closed
wants to merge 1 commit into from

Conversation

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Jan 28, 2021

Fix typo. Note, this change does not affect product because this code is not executed after JDK-8251994 fix:
https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/superword.cpp#L519


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2299/head:pull/2299
$ git checkout pull/2299

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 28, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@vnkozlov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 28, 2021

Webrevs

Loading

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine to me, thanks.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 28, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2)

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 81e9e6a: 8260461: Modernize jsr166 tck tests
  • 2b166d8: 8260596: Comment cleanup in BigInteger
  • 1de3c55: 8260584: Shenandoah: simplify "Concurrent Thread Roots" logging
  • bbbfaa5: 8249262: Initialize InstanceKlass::_package_entry during CDS dump time
  • 3aabbd7: 8260432: allocateSpaceForGP in freetypeScaler.c might leak memory
  • abc4300: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • 13ca433: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • baf46ba: 8259801: Enable XML Signature secure validation mode by default
  • 20e7df5: 8260466: Test TestHeapDumpOnOutOfMemoryError.java needs multiple @test sections
  • 11d6467: 8260407: cmp != __null && cmp->Opcode() == Op_CmpL failure with -XX:StressLongCountedLoop=200000000 in lucene
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/c7661aed6fed08154ed6754302687361f035d120...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 28, 2021
@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Jan 29, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 29, 2021
@vnkozlov vnkozlov deleted the JDK-8259584 branch Jan 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 29, 2021

@vnkozlov Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 6415d3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants