Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347302: Update ProcessTools.java to support virtual test factory for Xbootclasspath/a: #22993

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Jan 9, 2025

Test
runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java
uses
-Xbootclasspath/a: classpath
(2 arguments)

Such usage of options -Xbootclasspath/a: should be correctly processed by virtual thread factory support in ProcessTools.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8347302

Issue

  • JDK-8347302: Mark test tools/jimage/JImageToolTest.java as flagless (Enhancement - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22993/head:pull/22993
$ git checkout pull/22993

Update a local copy of the PR:
$ git checkout pull/22993
$ git pull https://git.openjdk.org/jdk.git pull/22993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22993

View PR using the GUI difftool:
$ git pr show -t 22993

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22993.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@lmesnik The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

@dholmes-ora
Copy link
Member

@lmesnik looks like you used the wrong bugid in this PR.

@dholmes-ora
Copy link
Member

-Xbootclasspath/a: does not accept a space between the ":" and the path! It should only be a single argument, not a double one.

@dholmes-ora
Copy link
Member

Note that in the test runtime/cds/appcds/jigsaw/modulepath/OptimizeModuleHandlingTest.java the cases with a space are expected to fail.

@lmesnik lmesnik closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants