Skip to content

Conversation

@bplb
Copy link
Member

@bplb bplb commented Jan 9, 2025

Change the test as done in #22957 for JDK-8346671.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22994/head:pull/22994
$ git checkout pull/22994

Update a local copy of the PR:
$ git checkout pull/22994
$ git pull https://git.openjdk.org/jdk.git pull/22994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22994

View PR using the GUI difftool:
$ git pr show -t 22994

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22994.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 9f3c5f9: 8344907: NullPointerException in Win32ShellFolder2.getSystemIcon when "icon" is null
  • 22f70a7: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image
  • 3bfa952: 8283795: Add TLSv1.3 and CNSA 1.0 algorithms to implementation requirements
  • 1ef77cd: 8347171: (dc) java/nio/channels/DatagramChannel/InterruptibleOrNot.java fails with virtual thread factory
  • 72f1114: 8346705: SNI not sent with Java 22+ using java.net.http.HttpClient.Builder#sslParameters
  • cb9a98b: 8347141: Several javac tests compile with an unnecessary -Xlint:-path flag
  • f9b1133: 8346880: [aix] java/lang/ProcessHandle/InfoTest.java still fails: "reported cputime less than expected"
  • 9c72ded: 8346036: Unnecessary Hashtable usage in javax.swing.text.html.parser.Entity
  • 3024a73: 8345782: Refining the cases that libjsig deprecation warning is issued
  • 2801bc6: 8346460: NotifyFramePop should return JVMTI_ERROR_DUPLICATE
  • ... and 14 more: https://git.openjdk.org/jdk/compare/0a5ef827b06ca9fc6a7cbc059e4331cfd3cd2e62...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025
@bplb
Copy link
Member Author

bplb commented Jan 10, 2025

Withholding integration until this change is verified on Windows Server 2025.

@bplb
Copy link
Member Author

bplb commented Jan 13, 2025

Change verified by "faking" OS name in the test.

@bplb
Copy link
Member Author

bplb commented Jan 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

Going to push as commit b0c131e.
Since your change was applied there have been 72 commits pushed to the master branch:

  • a7915bb: 8346468: SM cleanup of common test library
  • f67b703: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
  • 062f2dc: 8347554: [BACKOUT] C2: implement optimization for series of Add of unique value
  • a289bcf: 8306579: Consider building with /Zc:throwingNew
  • cede304: 8347482: Remove unused field in ParkEvent
  • fa5ff82: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set
  • cc19897: 8293123: Fix various include file ordering
  • 6e43f48: 8346929: runtime/ClassUnload/DictionaryDependsTest.java fails with "Test failed: should be unloaded"
  • c885e59: 8346377: Properly support static builds for Windows
  • 0612636: 8347373: HTTP/2 flow control checks may count unprocessed data twice
  • ... and 62 more: https://git.openjdk.org/jdk/compare/0a5ef827b06ca9fc6a7cbc059e4331cfd3cd2e62...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2025
@openjdk openjdk bot closed this Jan 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@bplb Pushed as commit b0c131e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the SpecialTempFile-8345368 branch January 13, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants