Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347289: HKDF delayed provider selection failed with non-extractable PRK #22995

Closed

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Jan 9, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347289: HKDF delayed provider selection failed with non-extractable PRK (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22995/head:pull/22995
$ git checkout pull/22995

Update a local copy of the PR:
$ git checkout pull/22995
$ git pull https://git.openjdk.org/jdk.git pull/22995/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22995

View PR using the GUI difftool:
$ git pr show -t 22995

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22995.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347289: HKDF delayed provider selection failed with non-extractable PRK

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the jdk24 branch:

  • ff9b8e4: 8346737: GenShen: Generational memory pools should not report zero for maximum capacity
  • 7d4fa78: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path
  • c033806: 8346739: jpackage tests failed after JDK-8345259
  • bf45128: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk24 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport db7fa6a2c65d11e5bd790073d345f37b5ec356b6 8347289: HKDF delayed provider selection failed with non-extractable PRK Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

Copy link
Contributor

@valeriepeng valeriepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025
@wangweij
Copy link
Contributor Author

wangweij commented Jan 9, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

Going to push as commit 864d0fd.
Since your change was applied there have been 4 commits pushed to the jdk24 branch:

  • ff9b8e4: 8346737: GenShen: Generational memory pools should not report zero for maximum capacity
  • 7d4fa78: 8345259: Disallow ALL-MODULE-PATH without explicit --module-path
  • c033806: 8346739: jpackage tests failed after JDK-8345259
  • bf45128: 8346872: tools/jpackage/windows/WinLongPathTest.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2025
@openjdk openjdk bot closed this Jan 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@wangweij Pushed as commit 864d0fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants