Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux #23

Closed
wants to merge 1 commit into from

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Sep 5, 2020

Bug :https://bugs.openjdk.java.net/browse/JDK-8252715

We've opened a bug to track some xserver issues running this test that cause all subsequent tests to fail
because they can't connect even though the server is still running.
Possibly it is a system configuration issue or perhaps an Xserver bug,
but it has been seen on more than one Ubuntu system running 19.10 and 20.04 and
I think we should problem list it to see if that cures/hides it .. or moves it .. as this happens
so frequently we can't wait for an investigation to complete.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/23/head:pull/23
$ git checkout pull/23

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 5, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@prrace To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d, awt, beans, build, compiler, core-libs, hotspot, hotspot-compiler, hotspot-gc, hotspot-jfr, hotspot-runtime, i18n, javadoc, jdk, jmx, kulla, net, nio, security, serviceability, shenandoah, sound, swing.

Loading

@prrace
Copy link
Contributor Author

@prrace prrace commented Sep 5, 2020

/label add awt

Loading

@openjdk openjdk bot added the awt label Sep 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@prrace
The awt label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 5, 2020

Webrevs

Loading

@@ -207,6 +207,7 @@ java/awt/event/KeyEvent/KeyChar/KeyCharTest.java 8169474,8224055 macosx-all,wind
java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java 6854300 generic-all
java/awt/event/KeyEvent/ExtendedModifiersTest/ExtendedModifiersTest.java 8129778 generic-all
java/awt/event/KeyEvent/KeyMaskTest/KeyMaskTest.java 8129778 generic-all
java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java 8252713 linux-all
java/awt/event/MouseEvent/MouseButtonsAndKeyMasksTest/MouseButtonsAndKeyMasksTest.java 8129778 generic-all
Copy link
Member

@mrserb mrserb Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test inline comment: Looks fine.

Loading

mrserb
mrserb approved these changes Sep 5, 2020
Copy link
Member

@mrserb mrserb left a comment

Looks fine

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@prrace This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8252715: Problem list java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java on Linux

Reviewed-by: serb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 4b3a0b789ebf389a9589c9af2d3922fb91916d92.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 5, 2020
@prrace
Copy link
Contributor Author

@prrace prrace commented Sep 5, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 5, 2020

@prrace Pushed as commit d0f4366. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants