Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253313: xmlstream.hpp missing from vmIntrinsics.cpp #230

Conversation

@iklam
Copy link
Member

@iklam iklam commented Sep 17, 2020

Please review this quick/trivial fix for for build breakage.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253313: xmlstream.hpp missing from vmIntrinsics.cpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/230/head:pull/230
$ git checkout pull/230

@iklam iklam marked this pull request as ready for review Sep 17, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@iklam The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

vidmik
vidmik approved these changes Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@iklam This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253313: xmlstream.hpp missing from vmIntrinsics.cpp

Reviewed-by: mikael
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 0a1dc50: 8253271: vm_version_x86.hpp should not include globals_extension.hpp

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 0a1dc50f543b7b56d69b218a4c0352184d63006e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 17, 2020
@iklam
Copy link
Member Author

@iklam iklam commented Sep 17, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@iklam Since your change was applied there has been 1 commit pushed to the master branch:

  • 0a1dc50: 8253271: vm_version_x86.hpp should not include globals_extension.hpp

Your commit was automatically rebased without conflicts.

Pushed as commit 6c3e483.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2020

Webrevs

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants