8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification

[egahlin]

Could I have a review that updates the specification for FlightRecorder::addListener to reflect that the Security Manager is now disabled.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8345610 to be approved

Issues

• JDK-8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification (Bug - P3)
• JDK-8345610: JFR: Remove AccessControlContext from FlightRecorder::addListener specification (CSR)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23006/head:pull/23006
$ git checkout pull/23006

Update a local copy of the PR:
$ git checkout pull/23006
$ git pull https://git.openjdk.org/jdk.git pull/23006/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23006

View PR using the GUI difftool:
$ git pr show -t 23006

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23006.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• c5c4efd: 8347120: Launchers should not have java headers on include path
• ec7393e: 8347287: JFR: Remove use of Security Manager
• 12752b0: 8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary
• 57af52c: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
• 1f45797: 8347124: Clean tests with --enable-linkable-runtime
• 5e92a4c: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero
• 55c6904: 8331717: C2: Crash with SIGFPE Because Loop Predication Wrongly Hoists Division Requiring Zero Check
• 1a0fe49: 8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level
• 8b07617: 8347345: Remove redundant test policy file from ModelMBeanInfoSupport directory
• f6492aa: 8347279: Problemlist TestEvilSyncBug.java#generational
• ... and 14 more: https://git.openjdk.org/jdk/compare/9c72dedd072e838d363d0eec364514584fd4e2e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9b18f90f)

[egahlin]

/integrate

[openjdk]

Going to push as commit 1bf2f5c.
Since your change was applied there have been 25 commits pushed to the master branch:

• beb0e60: 8347397: Cleanup of JDK-8169880
• c5c4efd: 8347120: Launchers should not have java headers on include path
• ec7393e: 8347287: JFR: Remove use of Security Manager
• 12752b0: 8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary
• 57af52c: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
• 1f45797: 8347124: Clean tests with --enable-linkable-runtime
• 5e92a4c: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero
• 55c6904: 8331717: C2: Crash with SIGFPE Because Loop Predication Wrongly Hoists Division Requiring Zero Check
• 1a0fe49: 8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level
• 8b07617: 8347345: Remove redundant test policy file from ModelMBeanInfoSupport directory
• ... and 15 more: https://git.openjdk.org/jdk/compare/9c72dedd072e838d363d0eec364514584fd4e2e6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 1bf2f5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[egahlin]

/backport :jdk24

[openjdk]

@egahlin the backport was successfully created on the branch backport-egahlin-1bf2f5c8-jdk24 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk24, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 1bf2f5c8 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 10 Jan 2025 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-egahlin-1bf2f5c8-jdk24:backport-egahlin-1bf2f5c8-jdk24
$ git checkout backport-egahlin-1bf2f5c8-jdk24
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-egahlin-1bf2f5c8-jdk24