Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk #23011

Closed
wants to merge 3 commits into from

Conversation

vy
Copy link
Contributor

@vy vy commented Jan 9, 2025

Switches from using the temporary directory to work directory in LoopingTruncate. This should effectively provide sufficient space for the test finish. Solution is tipped by @bplb. CI results are attached to the ticket.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk (Bug - P4)

Reviewers

Contributors

  • Brian Burkhalter <bpb@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23011/head:pull/23011
$ git checkout pull/23011

Update a local copy of the PR:
$ git checkout pull/23011
$ git pull https://git.openjdk.org/jdk.git pull/23011/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23011

View PR using the GUI difftool:
$ git pr show -t 23011

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23011.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back vy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk

Co-authored-by: Brian Burkhalter <bpb@openjdk.org>
Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • e0f2f4b: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
  • b0c131e: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025
  • a7915bb: 8346468: SM cleanup of common test library
  • f67b703: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
  • 062f2dc: 8347554: [BACKOUT] C2: implement optimization for series of Add of unique value
  • a289bcf: 8306579: Consider building with /Zc:throwingNew
  • cede304: 8347482: Remove unused field in ParkEvent
  • fa5ff82: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set
  • cc19897: 8293123: Fix various include file ordering
  • 6e43f48: 8346929: runtime/ClassUnload/DictionaryDependsTest.java fails with "Test failed: should be unloaded"
  • ... and 44 more: https://git.openjdk.org/jdk/compare/72f1114909854aaed5d190d1c74a98527600a0c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@vy The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@vy Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@vy
Copy link
Contributor Author

vy commented Jan 10, 2025

/contributor add @bplb

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@vy
Contributor Brian Burkhalter <bpb@openjdk.org> successfully added.

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2025
@vy
Copy link
Contributor Author

vy commented Jan 13, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@vy
Your change (at version 909572e) is now ready to be sponsored by a Committer.

@bplb
Copy link
Member

bplb commented Jan 13, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

Going to push as commit 4e0ffda.
Since your change was applied there have been 54 commits pushed to the master branch:

  • e0f2f4b: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
  • b0c131e: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025
  • a7915bb: 8346468: SM cleanup of common test library
  • f67b703: 8347427: JTabbedPane/8134116/Bug8134116.java has no license header
  • 062f2dc: 8347554: [BACKOUT] C2: implement optimization for series of Add of unique value
  • a289bcf: 8306579: Consider building with /Zc:throwingNew
  • cede304: 8347482: Remove unused field in ParkEvent
  • fa5ff82: 8342062: Reformat keytool and jarsigner output for keys with a named parameter set
  • cc19897: 8293123: Fix various include file ordering
  • 6e43f48: 8346929: runtime/ClassUnload/DictionaryDependsTest.java fails with "Test failed: should be unloaded"
  • ... and 44 more: https://git.openjdk.org/jdk/compare/72f1114909854aaed5d190d1c74a98527600a0c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2025
@openjdk openjdk bot closed this Jan 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@bplb @vy Pushed as commit 4e0ffda.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants