8326236: assert(ce != nullptr) failed in Continuation::continuation_bottom_sender

[pchilano]

Please review the following fix. In method frame::safe_for_sender() we could read a sender_pc that matches StubRoutines::cont_returnBarrier() but there is no actual continuation in the stack. I added more details in the bug comments on how we can get into this situation. The extra check verifies there is a ContinuationEntry further up in the stack. I run the patch through mach5 tiers 1-2 for sanity testing and tiers 6-7.

Thanks,
Patricio

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8326236: assert(ce != nullptr) failed in Continuation::continuation_bottom_sender (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23017/head:pull/23017
$ git checkout pull/23017

Update a local copy of the PR:
$ git checkout pull/23017
$ git pull https://git.openjdk.org/jdk.git pull/23017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23017

View PR using the GUI difftool:
$ git pr show -t 23017

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23017.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back pchilanomate! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pchilano This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326236: assert(ce != nullptr) failed in Continuation::continuation_bottom_sender

Reviewed-by: dholmes, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 122 new commits pushed to the master branch:

• 4c30933: 8346971: [ubsan] psCardTable.cpp:131:24: runtime error: large index is out of bounds
• 06ff4c1: 8347146: Convert IncludeLocalesPluginTest to use JUnit
• db76f47: 8347720: [BACKOUT] Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• e6902cf: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order
• a01e92c: 8347724: Replace SIZE_FORMAT in jfr directory
• d002933: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• d532019: 8347143: [aix] Fix strdup use in os::dll_load
• dfd215b: 8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413
• a49f833: 8346045: Cleanup of security library tests calling Security Manager APIs
• 56c7800: 8347381: Upgrade jQuery UI to version 1.14.1
• ... and 112 more: https://git.openjdk.org/jdk/compare/bcefab5e55d4527a38dcab550581a734c1564608...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@pchilano The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (58849fde)

[dholmes-ora]

Based on the analysis this seems quite reasonable.

Thanks

[pchilano]

Thanks for the reviews David and Markus!
/integrate

[openjdk]

Going to push as commit ec2aaaa.
Since your change was applied there have been 126 commits pushed to the master branch:

• 02d2493: 8347613: Remove leftover doPrivileged call in Currency test: CheckDataVersion.java
• 10d08db: 8346142: [perf] scalability issue for the specjvm2008::xml.validation workload
• 9b1bed0: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached"
• 2de71d0: 8347129: cpuset cgroups controller is required for no good reason
• 4c30933: 8346971: [ubsan] psCardTable.cpp:131:24: runtime error: large index is out of bounds
• 06ff4c1: 8347146: Convert IncludeLocalesPluginTest to use JUnit
• db76f47: 8347720: [BACKOUT] Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• e6902cf: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order
• a01e92c: 8347724: Replace SIZE_FORMAT in jfr directory
• d002933: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• ... and 116 more: https://git.openjdk.org/jdk/compare/bcefab5e55d4527a38dcab550581a734c1564608...master

Your commit was automatically rebased without conflicts.

[openjdk]

@pchilano Pushed as commit ec2aaaa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.