8346722: (fs) Files.probeContentType throws ClassCastException with custom file system provider

[bplb]

Ensure the file type detection works with a custom default file system provider.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346722: (fs) Files.probeContentType throws ClassCastException with custom file system provider (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23019/head:pull/23019
$ git checkout pull/23019

Update a local copy of the PR:
$ git checkout pull/23019
$ git pull https://git.openjdk.org/jdk.git pull/23019/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23019

View PR using the GUI difftool:
$ git pr show -t 23019

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23019.diff

Using Webrev

Link to Webrev Comment

[bplb]

/contributor add @AlanBateman

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346722: (fs) Files.probeContentType throws ClassCastException with custom file system provider

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• e7e8f60: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless
• 9cf7d42: 8346184: C2: assert(has_node(i)) failed during split thru phi
• 1bf2f5c: 8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification
• beb0e60: 8347397: Cleanup of JDK-8169880
• c5c4efd: 8347120: Launchers should not have java headers on include path
• ec7393e: 8347287: JFR: Remove use of Security Manager
• 12752b0: 8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary
• 57af52c: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
• 1f45797: 8347124: Clean tests with --enable-linkable-runtime
• 5e92a4c: 8347267: [macOS]: UnixOperatingSystem.c:67:40: runtime error: division by zero
• ... and 35 more: https://git.openjdk.org/jdk/compare/0a5ef827b06ca9fc6a7cbc059e4331cfd3cd2e62...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a8b205a7)
• 01: Full - Incremental (1be60915)
• 00: Full (f026d83b)

[AlanBateman]

We should probably add the @bug tag in SetDefaultProvider as we've been adding to this when adding tests for custom file system providers.

[bplb]

We should probably add the @bug tag in SetDefaultProvider [...].

Done in a8b205a.

[bplb]

/integrate

[openjdk]

Going to push as commit 4b554b5.
Since your change was applied there have been 46 commits pushed to the master branch:

• 46ba515: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args
• e7e8f60: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless
• 9cf7d42: 8346184: C2: assert(has_node(i)) failed during split thru phi
• 1bf2f5c: 8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification
• beb0e60: 8347397: Cleanup of JDK-8169880
• c5c4efd: 8347120: Launchers should not have java headers on include path
• ec7393e: 8347287: JFR: Remove use of Security Manager
• 12752b0: 8347346: Remove redundant ClassForName.java and test.policy from runtime/Dictionary
• 57af52c: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
• 1f45797: 8347124: Clean tests with --enable-linkable-runtime
• ... and 36 more: https://git.openjdk.org/jdk/compare/0a5ef827b06ca9fc6a7cbc059e4331cfd3cd2e62...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 4b554b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.