8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal

[kevinjwalls]

DescriptorSupport has a constructor and a method providing creation from, and export to, XML.

These are unused in the JDK and have no practical known examples of usage. XML parsing is best done by an independent implementation, not this class.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8347436 to be approved

Issues

• JDK-8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal (Enhancement - P4)
• JDK-8347436: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal (CSR)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23038/head:pull/23038
$ git checkout pull/23038

Update a local copy of the PR:
$ git checkout pull/23038
$ git pull https://git.openjdk.org/jdk.git pull/23038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23038

View PR using the GUI difftool:
$ git pr show -t 23038

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23038.diff

Using Webrev

Link to Webrev Comment

[kevinjwalls]

/csr

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347433: Deprecate XML interchange in java.management/javax/management/modelmbean/DescriptorSupport for removal

Reviewed-by: sspitsyn, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 105 new commits pushed to the master branch:

• 99fb350: 8350654: (fs) Files.createTempDirectory should say something about the default file permissions when no file attributes specified
• 768b024: 8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024
• c4b516d: 8348322: AOT cache creation crashes with "All cached hidden classes must be aot-linkable" when AOTInvokeDynamicLinking is disabled
• e470f47: 8350095: RISC-V: Refactor string_compare
• f53de92: 8350931: RISC-V: remove unnecessary src register for fp_sqrt_d/f
• e1fc14f: 8350940: RISC-V: remove unnecessary assert_different_registers in minmax_fp
• 79880e5: 8351033: RISC-V: TestFloat16ScalarOperations asserts with offset (4210) is too large to be patched in one beq/bge/bgeu/blt/bltu/bne instruction!
• bb70896: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest
• 7c187b5: 8338737: Shenandoah: Reset marking bitmaps after the cycle
• 3602c8c: 8350955: Fix repetitions of the word "the" in runtime component comments
• ... and 95 more: https://git.openjdk.org/jdk/compare/e410af00e69587b86536b298b869ddc898fd9862...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinjwalls The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinjwalls please create a CSR request for issue JDK-8347433 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[mlbridge]

Webrevs

• 03: Full - Incremental (acdfef2b)
• 02: Full - Incremental (04d627c7)
• 01: Full - Incremental (1d236064)
• 00: Full (f1aeaf95)

[bridgekeeper]

@kevinjwalls This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[kevinjwalls]

Thanks for the comments @dfuch
Added the "can be implemented externally" wording.

I'm adding comments about XMLParseException usage, one for each use, which is quite verbose BUT temporary, as this is all about planning for imminent removal.

(Looking around at other uses of @SuppressWarnings("removal") I didn't find one where we spell out in a comment exactly what is for removal that we are suppressing.)

[sspitsyn]

This fix looks okay. Posted one question though.

[kevinjwalls]

Thanks for the reviews!

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 54fe643.
Since your change was applied there have been 159 commits pushed to the master branch:

• 155697f: 8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails
• 4066f33: 8350565: NMT: remaining memory flag/type to be replaced with memory tag
• 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
• 7c9a784: 8351223: Update localized resources in keytool and jarsigner
• a23fb0a: 8348110: Update LCMS to 2.17
• 0892913: 8351086: (fc) Make java/nio/channels/FileChannel/BlockDeviceSize.java test manual
• 93f2260: 8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}
• 8f8a879: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean
• cfab88b: 8351256: Improve printing of runtime call stub names in disassember output
• 7a5acb9: 8343840: Rewrite the ObjectMonitor lists
• ... and 149 more: https://git.openjdk.org/jdk/compare/e410af00e69587b86536b298b869ddc898fd9862...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 54fe643.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.