8347434: Richer VM operations events logging

[shipilev]

A simpler quality of diagnostics improvement. In hs_err, it is not abundantly clear if executed VM operations took safepoint or not, were nested or not. It would be good to print that out.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347434: Richer VM operations events logging (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Johan Sjölen (@jdksjolen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23039/head:pull/23039
$ git checkout pull/23039

Update a local copy of the PR:
$ git checkout pull/23039
$ git pull https://git.openjdk.org/jdk.git pull/23039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23039

View PR using the GUI difftool:
$ git pr show -t 23039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23039.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347434: Richer VM operations events logging

Reviewed-by: dholmes, jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• c207cc7: 8347923: Parallel: Simplify compute_survivor_space_size_and_threshold
• 4b4b1e9: 8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt
• e7a1c86: 8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST
• 644d154: 8347474: Options singleton is used before options are parsed
• 3804082: 8346123: [REDO] NMT should not use ThreadCritical
• 1f0efc0: 8347343: RISC-V: Unchecked zicntr csr reads
• ca8ba5c: 8347366: RISC-V: Add extension asserts for CMO instructions
• 0ff6700: 8347987: Bad ifdef in 8330851
• e1cf351: 8348013: [doc] fix typo in java.md caused by JDK-8347763
• 6ef860c: 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed
• ... and 9 more: https://git.openjdk.org/jdk/compare/a3eef6c2416eb0e02fbd154d84c98b12bcb66e97...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Example log before:

VM Operations (10 events):
Event: 0.069 Executing VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.069 Executing VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.213 Executing VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.213 Executing VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.486 Executing VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.486 Executing VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.579 Executing VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.579 Executing VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.596 Executing VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.596 Executing VM operation: HandshakeAllThreads (Deoptimize) done

...and after:

VM Operations (10 events):
Event: 0.065 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.065 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.191 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.191 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.423 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.423 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.506 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.506 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize) done
Event: 0.519 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize)
Event: 0.519 Executing non-safepoint VM operation: HandshakeAllThreads (Deoptimize) done

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9b562f71)
• 00: Full (c3b2f863)

[dholmes-ora]

A couple of suggestions but I'll approve anyway.

[dholmes-ora]

LGTM!

Thanks

[shipilev]

Thanks for reviews!

/integrate

[openjdk]

Going to push as commit 85fdd2c.
Since your change was applied there have been 19 commits pushed to the master branch:

• c207cc7: 8347923: Parallel: Simplify compute_survivor_space_size_and_threshold
• 4b4b1e9: 8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt
• e7a1c86: 8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST
• 644d154: 8347474: Options singleton is used before options are parsed
• 3804082: 8346123: [REDO] NMT should not use ThreadCritical
• 1f0efc0: 8347343: RISC-V: Unchecked zicntr csr reads
• ca8ba5c: 8347366: RISC-V: Add extension asserts for CMO instructions
• 0ff6700: 8347987: Bad ifdef in 8330851
• e1cf351: 8348013: [doc] fix typo in java.md caused by JDK-8347763
• 6ef860c: 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed
• ... and 9 more: https://git.openjdk.org/jdk/compare/a3eef6c2416eb0e02fbd154d84c98b12bcb66e97...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 85fdd2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.