Skip to content

Conversation

@arend-von-reinersdorff
Copy link

@arend-von-reinersdorff arend-von-reinersdorff commented Jan 11, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8351505

Warnings

 ⚠️ Patch contains a binary file (src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/glass.png)
 ⚠️ Patch contains a binary file (src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/x.png)

Issue

  • JDK-8351505: (fs) Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() (Bug - P4) ⚠️ Title mismatch between PR and JBS. ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23052/head:pull/23052
$ git checkout pull/23052

Update a local copy of the PR:
$ git checkout pull/23052
$ git pull https://git.openjdk.org/jdk.git pull/23052/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23052

View PR using the GUI difftool:
$ git pr show -t 23052

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23052.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2025

Hi @arend-von-reinersdorff, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user arend-von-reinersdorff" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jan 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 11, 2025

@arend-von-reinersdorff The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jan 11, 2025
@arend-von-reinersdorff
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jan 24, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2025

@arend-von-reinersdorff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@arend-von-reinersdorff
Copy link
Author

ping

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2025

@arend-von-reinersdorff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@arend-von-reinersdorff
Copy link
Author

ping

@jaikiran
Copy link
Member

Hello Arend, the JDK project relies on Skara bots to generate a RFR (request for review) email to the relevant mailing list. One requirement before generating the RFR is to have an issue created for the PR in the JDK issue tracker. For issues like these, the typical process is to first create a bug here https://bugs.java.com/bugdatabase/ and once the bug has been triaged and a bug id allocated, you can create a PR for it. More details about the contribution guidelines are available here https://openjdk.org/guide/#contributing-to-an-openjdk-project.

As for this specific change, this does look like a genuine typo in the documentation. I've created a bug for you here https://bugs.openjdk.org/browse/JDK-8351505. Please edit the title of this PR to 8351505: Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() so that it gets picked up by the bots to trigger the review process.

@arend-von-reinersdorff arend-von-reinersdorff changed the title Add missing words in FileSystemProvider.getFileSystem() Javadoc 8351505: Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() Mar 15, 2025
@openjdk
Copy link

openjdk bot commented Mar 15, 2025

@arend-von-reinersdorff this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout patch-1
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review labels Mar 15, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2025

Webrevs

@arend-von-reinersdorff
Copy link
Author

@jaikiran thank you for creating the issue :-) Has in the meantime been fixed by #23968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict Pull request has merge conflict with target branch nio nio-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants