-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8351505: Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() #23052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8351505: Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() #23052
Conversation
|
Hi @arend-von-reinersdorff, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user arend-von-reinersdorff" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
@arend-von-reinersdorff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
@arend-von-reinersdorff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
ping |
|
@arend-von-reinersdorff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
ping |
|
Hello Arend, the JDK project relies on Skara bots to generate a RFR (request for review) email to the relevant mailing list. One requirement before generating the RFR is to have an issue created for the PR in the JDK issue tracker. For issues like these, the typical process is to first create a bug here https://bugs.java.com/bugdatabase/ and once the bug has been triaged and a bug id allocated, you can create a PR for it. More details about the contribution guidelines are available here https://openjdk.org/guide/#contributing-to-an-openjdk-project. As for this specific change, this does look like a genuine typo in the documentation. I've created a bug for you here https://bugs.openjdk.org/browse/JDK-8351505. Please edit the title of this PR to |
|
@arend-von-reinersdorff this pull request can not be integrated into git checkout patch-1
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Progress
Integration blocker
Warnings
Issue
Backport <hash>with the hash of the original commit. See Backports.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23052/head:pull/23052$ git checkout pull/23052Update a local copy of the PR:
$ git checkout pull/23052$ git pull https://git.openjdk.org/jdk.git pull/23052/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23052View PR using the GUI difftool:
$ git pr show -t 23052Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23052.diff