Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347302: Mark test tools/jimage/JImageToolTest.java as flagless #23058

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 13, 2025

Hi all,

This pull request contains a backport of commit e7e8f60c from the openjdk/jdk repository to jdk24.

Test test/jdk/tools/jimage/JImageToolTest.java ignore vm flags and should be marked as flagless. Test-fix only, no risk.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347302: Mark test tools/jimage/JImageToolTest.java as flagless (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23058/head:pull/23058
$ git checkout pull/23058

Update a local copy of the PR:
$ git checkout pull/23058
$ git pull https://git.openjdk.org/jdk.git pull/23058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23058

View PR using the GUI difftool:
$ git pr show -t 23058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23058.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e7e8f60c9bedd5622525cc4339300b438eedc9fd 8347302: Mark test tools/jimage/JImageToolTest.java as flagless Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 13, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2025

Webrevs

@kevinrushforth
Copy link
Member

As we are now in the Release Candidate phase of JDK 24, this fix is no longer suitable for JDK 24. See JEP 3 for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants