8347562: javac crash due to type vars in permits clause

[SirYwell]

This fix ignores erroneous types when attributing permits clauses. Before, multiple erroneous types would lead to an exception in the duplication check. Additionally, such types would cause package mismatch errors. As javac already reports errors before, such an additional error is more confusing than helpful.

Note that there are additional type var checks, but those only apply if the type vars come from a type other than the type with the permits clause, i.e. an enclosing class.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8347562: javac crash due to type vars in permits clause

Issue

• JDK-8347562: javac crash due to type vars in permits clause (Bug - P4)

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23069/head:pull/23069
$ git checkout pull/23069

Update a local copy of the PR:
$ git checkout pull/23069
$ git pull https://git.openjdk.org/jdk.git pull/23069/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23069

View PR using the GUI difftool:
$ git pr show -t 23069

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23069.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back hgreule! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SirYwell This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347562: javac crash due to type vars in permits clause

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• af3f5d8: 8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running
• 91197b3: 8347531: The signal tests are failing after JDK-8345782 due to an unrelated warning
• 4f3dc9d: 8347352: RISC-V: Cleanup bitwise AND assembler routines
• afc4529: 8346834: Tests failing with -XX:+UseNUMA due to "NUMA support disabled" warning
• a3be97e: 8347761: Test tools/jimage/JImageExtractTest.java fails after JDK-8303884
• 28e01e6: 8347762: ClassFile attribute specification refers to non-SE modules
• be1cdd9: 8344140: Refactor the discovery of AOT cache artifacts
• 973c630: 8342466: Improve API documentation for java.lang.classfile.attribute
• 9782bfd: 8347620: Shenandoah: Use 'free' tag for free set related logging
• 35be4a4: 8347173: java/net/DatagramSocket/InterruptibleDatagramSocket.java fails with virtual thread factory
• ... and 49 more: https://git.openjdk.org/jdk/compare/450636ae28b84ded083b6861c6cba85fbf87e16e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@SirYwell The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (41bbac88)
• 01: Full - Incremental (f8b7c2fb)
• 00: Full (7d51b793)

[vicente-romero-oracle]

lgtm

[vicente-romero-oracle]

lgtm

[SirYwell]

Thank you for your review!

/integrate

[openjdk]

@SirYwell
Your change (at version 41bbac8) is now ready to be sponsored by a Committer.

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit 8193ba3.
Since your change was applied there have been 63 commits pushed to the master branch:

• 7df21a8: 8347597: HttpClient: improve exception reporting when closing connection
• b0e2be6: 8347729: Replace SIZE_FORMAT in parallel and serial gc
• d4e5ec2: 8346610: Make all imports consistent in the FFM API
• c36200b: 8347721: Replace SIZE_FORMAT in compiler directories
• af3f5d8: 8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running
• 91197b3: 8347531: The signal tests are failing after JDK-8345782 due to an unrelated warning
• 4f3dc9d: 8347352: RISC-V: Cleanup bitwise AND assembler routines
• afc4529: 8346834: Tests failing with -XX:+UseNUMA due to "NUMA support disabled" warning
• a3be97e: 8347761: Test tools/jimage/JImageExtractTest.java fails after JDK-8303884
• 28e01e6: 8347762: ClassFile attribute specification refers to non-SE modules
• ... and 53 more: https://git.openjdk.org/jdk/compare/450636ae28b84ded083b6861c6cba85fbf87e16e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @SirYwell Pushed as commit 8193ba3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.