-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8346045: Cleanup of security library tests calling Security Manager APIs #23070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mullan! A progress list of the required criteria for merging this PR into |
|
@seanjmullan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@seanjmullan The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
dfuch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to SimpleSSLContext LGTM. Nice simplification!
RogerRiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup.
|
/integrate |
|
@seanjmullan Since your change was applied there have been 132 commits pushed to the
It was not possible to rebase your changes automatically. Please merge |
|
@seanjmullan this pull request can not be integrated into git checkout JDK-8346045
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
RogerRiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after merge
|
/integrate |
|
@seanjmullan Pushed as commit a49f833. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Some additional removal of calls to SM APIs from security library tests. One test is removed since it is no longer an issue.
Progress
Issue
Backport <hash>with the hash of the original commit. See Backports.Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23070/head:pull/23070$ git checkout pull/23070Update a local copy of the PR:
$ git checkout pull/23070$ git pull https://git.openjdk.org/jdk.git pull/23070/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23070View PR using the GUI difftool:
$ git pr show -t 23070Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23070.diff
Using Webrev
Link to Webrev Comment