Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java #23085

Closed
wants to merge 2 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Jan 13, 2025

Remove testing on Windows of file extensions which do not consistently map to the same content type across different versions of Windows.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23085/head:pull/23085
$ git checkout pull/23085

Update a local copy of the PR:
$ git checkout pull/23085
$ git pull https://git.openjdk.org/jdk.git pull/23085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23085

View PR using the GUI difftool:
$ git pr show -t 23085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23085.diff

Using Webrev

Link to Webrev Comment

@bplb
Copy link
Member Author

bplb commented Jan 13, 2025

This change should eliminate future problems which are likely to occur as new versions of Windows appear.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • a49f833: 8346045: Cleanup of security library tests calling Security Manager APIs
  • 56c7800: 8347381: Upgrade jQuery UI to version 1.14.1
  • 1c64a45: 8347501: Make static-launcher fails after JDK-8346669
  • b4cd3b1: 8347566: Replace SSIZE_FORMAT with 'z' length modifier
  • f0af830: 8335747: C2: fix overflow case for LoopLimit with constant inputs
  • fec769b: 8346778: Enable native access should work with the source launcher
  • cbb2b84: 8344130: C2: Avoid excessive hoisting in scheduler due to minuscule differences in block frequency
  • bb93f67: 8347646: module-info classfile missing the preview flag
  • 3e989fd: 8346986: Remove ASM from java.base
  • 3967696: 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac
  • ... and 13 more: https://git.openjdk.org/jdk/compare/a7915bb2e1b822b6d9cbeb220765e8c821c71d0b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 13, 2025
@openjdk
Copy link

openjdk bot commented Jan 13, 2025

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jan 13, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 14, 2025
Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 14, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 14, 2025
@bplb
Copy link
Member Author

bplb commented Jan 14, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 14, 2025

Going to push as commit d002933.
Since your change was applied there have been 25 commits pushed to the master branch:

  • d532019: 8347143: [aix] Fix strdup use in os::dll_load
  • dfd215b: 8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413
  • a49f833: 8346045: Cleanup of security library tests calling Security Manager APIs
  • 56c7800: 8347381: Upgrade jQuery UI to version 1.14.1
  • 1c64a45: 8347501: Make static-launcher fails after JDK-8346669
  • b4cd3b1: 8347566: Replace SSIZE_FORMAT with 'z' length modifier
  • f0af830: 8335747: C2: fix overflow case for LoopLimit with constant inputs
  • fec769b: 8346778: Enable native access should work with the source launcher
  • cbb2b84: 8344130: C2: Avoid excessive hoisting in scheduler due to minuscule differences in block frequency
  • bb93f67: 8347646: module-info classfile missing the preview flag
  • ... and 15 more: https://git.openjdk.org/jdk/compare/a7915bb2e1b822b6d9cbeb220765e8c821c71d0b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 14, 2025
@openjdk openjdk bot closed this Jan 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 14, 2025
@openjdk
Copy link

openjdk bot commented Jan 14, 2025

@bplb Pushed as commit d002933.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the FileType-pruning-8347286 branch January 14, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants