8347613: Remove leftover doPrivileged call in Currency test: CheckDataVersion.java

[justin-curtis-lu]

Please review this PR which removes a leftover doPrivileged call in the Currency test, CheckDataVersion.java.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347613: Remove leftover doPrivileged call in Currency test: CheckDataVersion.java (Bug - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23087/head:pull/23087
$ git checkout pull/23087

Update a local copy of the PR:
$ git checkout pull/23087
$ git pull https://git.openjdk.org/jdk.git pull/23087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23087

View PR using the GUI difftool:
$ git pr show -t 23087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23087.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347613: Remove leftover doPrivileged call in Currency test: CheckDataVersion.java

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

• 379d05b: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros
• d3a7ac2: 8346383: Cannot use DllMain in libdt_socket for static builds
• 13a1775: 8344146: Remove temporary font file tracking code.
• 61dc07c: 8346869: [AIX] Add regression test for handling 4 Byte aligned doubles in structures
• 13e1ea5: 8346038: [REDO] - [C1] LIR Operations with one input should be implemented as LIR_Op1
• 7c883c2: 8347605: Use spec tag to refer to IEEE 754 standard
• 4e0ffda: 8346972: Test java/nio/channels/FileChannel/LoopingTruncate.java fails sometimes with IOException: There is not enough space on the disk
• e0f2f4b: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• b0c131e: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025
• a7915bb: 8346468: SM cleanup of common test library
• ... and 111 more: https://git.openjdk.org/jdk/compare/27646e551686ec02740600fc73694fc2fbd00a88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (aafade3f)
• 00: Full (b2d0edfd)

[naotoj]

IOException could happen not by the test setup failure, but for the case the currency.data file in the JDK is missing or corrupt, so if you want to give extra message to the exception, needs some rewording. Also, I prefer ioe should be the cause and not to be consumed in the message.

[justin-curtis-lu]

Ah, I meant that if currency.data was missing/corrupted, it was a set up failure because we can not test the contents properly. Although, I suppose that just means the test fails, not fails to setup properly. Updated the message to be more clear, and also used the 2 arg ctor to retain the IOE as you suggested.

[naotoj]

LGTM

[justin-curtis-lu]

/integrate

[openjdk]

Going to push as commit 02d2493.
Since your change was applied there have been 146 commits pushed to the master branch:

• 10d08db: 8346142: [perf] scalability issue for the specjvm2008::xml.validation workload
• 9b1bed0: 8290043: serviceability/attach/ConcAttachTest.java failed "guarantee(!CheckJNICalls) failed: Attached JNI thread exited without being detached"
• 2de71d0: 8347129: cpuset cgroups controller is required for no good reason
• 4c30933: 8346971: [ubsan] psCardTable.cpp:131:24: runtime error: large index is out of bounds
• 06ff4c1: 8347146: Convert IncludeLocalesPluginTest to use JUnit
• db76f47: 8347720: [BACKOUT] Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION
• e6902cf: 8323740: java.lang.ExceptionInInitializerError when trying to load XML classes in wrong order
• a01e92c: 8347724: Replace SIZE_FORMAT in jfr directory
• d002933: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• d532019: 8347143: [aix] Fix strdup use in os::dll_load
• ... and 136 more: https://git.openjdk.org/jdk/compare/27646e551686ec02740600fc73694fc2fbd00a88...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit 02d2493.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.