8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413

[slowhog]

Sort services provided by a module to ensure reproduce same result.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413 (Bug - P2)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Ioi Lam (@iklam - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23088/head:pull/23088
$ git checkout pull/23088

Update a local copy of the PR:
$ git checkout pull/23088
$ git pull https://git.openjdk.org/jdk.git pull/23088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23088

View PR using the GUI difftool:
$ git pr show -t 23088

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23088.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back henryjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@slowhog This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347376: tools/jlink/runtimeImage/JavaSEReproducibleTest.java and PackagedModulesVsRuntimeImageLinkTest.java failed after JDK-8321413

Reviewed-by: dholmes, iklam, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• c1d322f: 8347627: Compiler replay tests are failing after JDK-8346990
• 0ae5c6b: 8342996: Enhance Attach API to support arbitrary length arguments - OSX
• 91b63ca: 8345016: [ASAN] java.c reported ‘%s’ directive argument is null [-Werror=format-truncation=]
• 379d05b: 8346990: Remove INTX_FORMAT and UINTX_FORMAT macros
• d3a7ac2: 8346383: Cannot use DllMain in libdt_socket for static builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@slowhog The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5f4796fd)

[dholmes-ora]

Seems reasonable.

Thanks for fixing.

[iklam]

LGTM

[slowhog]

/integrate

[openjdk]

Going to push as commit dfd215b.
Since your change was applied there have been 16 commits pushed to the master branch:

• a49f833: 8346045: Cleanup of security library tests calling Security Manager APIs
• 56c7800: 8347381: Upgrade jQuery UI to version 1.14.1
• 1c64a45: 8347501: Make static-launcher fails after JDK-8346669
• b4cd3b1: 8347566: Replace SSIZE_FORMAT with 'z' length modifier
• f0af830: 8335747: C2: fix overflow case for LoopLimit with constant inputs
• fec769b: 8346778: Enable native access should work with the source launcher
• cbb2b84: 8344130: C2: Avoid excessive hoisting in scheduler due to minuscule differences in block frequency
• bb93f67: 8347646: module-info classfile missing the preview flag
• 3e989fd: 8346986: Remove ASM from java.base
• 3967696: 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac
• ... and 6 more: https://git.openjdk.org/jdk/compare/13a1775718f329b02cdeb82f9d3f7d878ac5e771...master

Your commit was automatically rebased without conflicts.

[openjdk]

@slowhog Pushed as commit dfd215b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.