Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253314: precompiled.hpp missing from vmIntrinsics.cpp #231

Conversation

@iklam
Copy link
Member

@iklam iklam commented Sep 17, 2020

Sorry, please review yet another trivial fix for build breakage.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253314: precompiled.hpp missing from vmIntrinsics.cpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/231/head:pull/231
$ git checkout pull/231

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2020

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@iklam The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2020

Webrevs

Loading

vidmik
vidmik approved these changes Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@iklam This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253314: precompiled.hpp missing from vmIntrinsics.cpp

Reviewed-by: mikael
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate d4269fd52062f98d16524299eed98e8d81c0cbbb.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 17, 2020
@iklam
Copy link
Member Author

@iklam iklam commented Sep 17, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@iklam Pushed as commit 2c3a37c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Sep 17, 2020

@iklam - I had tested the PR that introduced this build break only using a release config (and more recently on a fastdebug). What other config did I miss beside fastdebug?

Sorry for all this trouble.

Loading

@coleenp
Copy link
Contributor

@coleenp coleenp commented Sep 17, 2020

Sorry I feel guilty because I suggested removing unneeded header files. Does the external submit still work?

Loading

@iklam
Copy link
Member Author

@iklam iklam commented Sep 17, 2020

@iklam - I had tested the PR that introduced this build break only using a release config (and more recently on a fastdebug). What other config did I miss beside fastdebug?

Sorry for all this trouble.

Our continuous integration pipeline tests a variety of builds. Some are configured with --disable-precompiled-headers, which detected JDK-8253313. We also have Windows builds, which enable PCH and require that each file has precompiled.hpp.

I was my fault. As a sponsor, I should have tested the changes before integrating the code.

Loading

@iklam
Copy link
Member Author

@iklam iklam commented Sep 17, 2020

Sorry I feel guilty because I suggested removing unneeded header files. Does the external submit still work?

The pull request command /test should provide a way for external developers to do a basic build test, but I think it's not fully working yet.

Loading

@JohnTortugo
Copy link
Contributor

@JohnTortugo JohnTortugo commented Sep 17, 2020

Thanks for clarifying. I should've tested better as well. I'll see with my peers here at MS to see if we can expand the range of configurations that we test.

The pull request command /test should provide a way for external developers to do a basic build test, but I think it's not fully working yet.

Thanks. I'll try that next time!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants