-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347720: [BACKOUT] Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION #23110
Conversation
…OW_C_FUNCTION" This reverts commit e0f2f4b.
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@kimbarrett The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backout looks good.
Thanks for review @coleenp |
/integrate |
Going to push as commit db76f47.
Your commit was automatically rebased without conflicts. |
@kimbarrett Pushed as commit db76f47. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backout of JDK-8313396.
This reverts commit e0f2f4b.
Testing: mach5 tier1
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23110/head:pull/23110
$ git checkout pull/23110
Update a local copy of the PR:
$ git checkout pull/23110
$ git pull https://git.openjdk.org/jdk.git pull/23110/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23110
View PR using the GUI difftool:
$ git pr show -t 23110
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23110.diff
Using Webrev
Link to Webrev Comment