-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347347: Build fails undefined symbol: __asan_init by clang17 #23124
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for this current approach. I wonder if it's possible to use static ASAN for clang somehow though
Thanks all for the reviews. /integrate |
Going to push as commit e7795cc.
Your commit was automatically rebased without conflicts. |
@sendaoYan Pushed as commit e7795cc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This PR fix the bugs which build fails "undefined symbol: __asan_init" by clang17 with configure parameter "--enable-asan".
With clang, -static-libsan is the default, -shared-libsan forces the linker to use the shared asan run-time. And with gcc there is no this issue.
This PR append
-shared-libasan
link flags toASAN_LDFLAGS
will fix the make failure. The change has been verified locally, risk is low.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23124/head:pull/23124
$ git checkout pull/23124
Update a local copy of the PR:
$ git checkout pull/23124
$ git pull https://git.openjdk.org/jdk.git pull/23124/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23124
View PR using the GUI difftool:
$ git pr show -t 23124
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23124.diff
Using Webrev
Link to Webrev Comment