Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347347: Build fails undefined symbol: __asan_init by clang17 #23124

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 15, 2025

Hi all,
This PR fix the bugs which build fails "undefined symbol: __asan_init" by clang17 with configure parameter "--enable-asan".
With clang, -static-libsan is the default, -shared-libsan forces the linker to use the shared asan run-time. And with gcc there is no this issue.
This PR append -shared-libasan link flags to ASAN_LDFLAGS will fix the make failure. The change has been verified locally, risk is low.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347347: Build fails undefined symbol: __asan_init by clang17 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23124/head:pull/23124
$ git checkout pull/23124

Update a local copy of the PR:
$ git checkout pull/23124
$ git pull https://git.openjdk.org/jdk.git pull/23124/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23124

View PR using the GUI difftool:
$ git pr show -t 23124

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23124.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 15, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347347: Build fails undefined symbol: __asan_init by clang17

Reviewed-by: erikj, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 7df21a8: 8347597: HttpClient: improve exception reporting when closing connection
  • b0e2be6: 8347729: Replace SIZE_FORMAT in parallel and serial gc
  • d4e5ec2: 8346610: Make all imports consistent in the FFM API
  • c36200b: 8347721: Replace SIZE_FORMAT in compiler directories
  • af3f5d8: 8347039: ThreadPerTaskExecutor terminates if cancelled tasks still running
  • 91197b3: 8347531: The signal tests are failing after JDK-8345782 due to an unrelated warning
  • 4f3dc9d: 8347352: RISC-V: Cleanup bitwise AND assembler routines
  • afc4529: 8346834: Tests failing with -XX:+UseNUMA due to "NUMA support disabled" warning
  • a3be97e: 8347761: Test tools/jimage/JImageExtractTest.java fails after JDK-8303884
  • 28e01e6: 8347762: ClassFile attribute specification refers to non-SE modules
  • ... and 1 more: https://git.openjdk.org/jdk/compare/973c630777d4075bc85c7ddc1eb02cc65904344d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 15, 2025
@openjdk
Copy link

openjdk bot commented Jan 15, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jan 15, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 15, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 15, 2025
Copy link
Contributor

@TheShermanTanker TheShermanTanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for this current approach. I wonder if it's possible to use static ASAN for clang somehow though

@sendaoYan
Copy link
Member Author

Thanks all for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2025

Going to push as commit e7795cc.
Since your change was applied there have been 31 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2025
@openjdk openjdk bot closed this Jan 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2025
@openjdk
Copy link

openjdk bot commented Jan 16, 2025

@sendaoYan Pushed as commit e7795cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8347347 branch January 16, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants