-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347731: Replace SIZE_FORMAT in zgc #23133
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks Stefan, Thomas and Joel for reviewing! |
Going to push as commit 8bfa540.
Your commit was automatically rebased without conflicts. |
Please review this change to replace SIZE_FORMAT with %zu in the zgc directory. The only hand edit that I did for this one was SIZE_FORMAT_W(7) because my sed script had problems with it. There's a %zx in this change which I carefully made 0x%zx rather than %#zx.
Tested with tier1-4 with the other GC changes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23133/head:pull/23133
$ git checkout pull/23133
Update a local copy of the PR:
$ git checkout pull/23133
$ git pull https://git.openjdk.org/jdk.git pull/23133/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23133
View PR using the GUI difftool:
$ git pr show -t 23133
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23133.diff
Using Webrev
Link to Webrev Comment