Skip to content

8260462: Missing <thead> in Modality.html #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jan 29, 2021

The first row in The Standard Blocking Matrix table in The AWT Modality (Modality.html) is a header row and it should be inside <thead> element.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2314/head:pull/2314
$ git checkout pull/2314

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2021

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@aivanov-jdk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Jan 29, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260462: Missing <thead> in Modality.html

Reviewed-by: serb, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 6b24e98: 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB
  • 69ee314: 8249867: xml declaration is not followed by a newline
  • fb46c91: 8260674: ProblemList jdk/incubator/vector/VectorHash.java in Xcomp configs
  • 71bfe96: 8217633: Configurable extensions with system properties
  • f5ca838: 8065773: JDI: UOE is not thrown, when redefineClasses changes a class modifier
  • 739bbd0: 8260566: Pattern type X is a subtype of expression type Y message is incorrect
  • b2e582a: 8259905: Compiler treats 'sealed' keyword as 'var' keyword
  • 6415d3b: 8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2)
  • b7b391b: 8260625: Rename MetaspaceExpand_lock
  • 22bfa5b: 8255837: Shenandoah: Remove ShenandoahConcurrentRoots class
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/0675473486bc0ee321654d308b600874cf5ce41e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 29, 2021
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2021
@openjdk
Copy link

openjdk bot commented Jan 30, 2021

@aivanov-jdk Since your change was applied there have been 15 commits pushed to the master branch:

  • 67a34da: 8260630: Templatize literal_size
  • 6b24e98: 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB
  • 69ee314: 8249867: xml declaration is not followed by a newline
  • fb46c91: 8260674: ProblemList jdk/incubator/vector/VectorHash.java in Xcomp configs
  • 71bfe96: 8217633: Configurable extensions with system properties
  • f5ca838: 8065773: JDI: UOE is not thrown, when redefineClasses changes a class modifier
  • 739bbd0: 8260566: Pattern type X is a subtype of expression type Y message is incorrect
  • b2e582a: 8259905: Compiler treats 'sealed' keyword as 'var' keyword
  • 6415d3b: 8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2)
  • b7b391b: 8260625: Rename MetaspaceExpand_lock
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/0675473486bc0ee321654d308b600874cf5ce41e...master

Your commit was automatically rebased without conflicts.

Pushed as commit fcfe647.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the JDK-8260462 branch February 18, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants