8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST

[vy]

Hardens URI build in AbstractConnectTimeoutHandshake, which is extended by both ConnectTimeoutHandshakeSync and ConnectTimeoutHandshakeAsync.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23162/head:pull/23162
$ git checkout pull/23162

Update a local copy of the PR:
$ git checkout pull/23162
$ git pull https://git.openjdk.org/jdk.git pull/23162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23162

View PR using the GUI difftool:
$ git pr show -t 23162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23162.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8217914: java/net/httpclient/ConnectTimeoutHandshakeSync.java failed on connection refused while doing POST

Reviewed-by: dfuchs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 644d154: 8347474: Options singleton is used before options are parsed
• 3804082: 8346123: [REDO] NMT should not use ThreadCritical
• 1f0efc0: 8347343: RISC-V: Unchecked zicntr csr reads
• ca8ba5c: 8347366: RISC-V: Add extension asserts for CMO instructions
• 0ff6700: 8347987: Bad ifdef in 8330851
• e1cf351: 8348013: [doc] fix typo in java.md caused by JDK-8347763
• 6ef860c: 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed
• 17e3df6: 8347763: [doc] Add documentation of module options for JEP 483
• 6cc1c0a: 8347422: Crash during safepoint handler execution with -XX:+UseAPX
• baca7da: 8347733: Replace SIZE_FORMAT in runtime code
• ... and 11 more: https://git.openjdk.org/jdk/compare/07a0dcbabcb1216211c1da75f6dd2582da194df9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@vy The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a7559023)

[vy]

Successful tier1 and tier2 results on a755902 are attached to the ticket.

[dfuch]

LGTM

[vy]

/integrate

[openjdk]

@vy
Your change (at version a755902) is now ready to be sponsored by a Committer.

[jaikiran]

The change to use loopback address in the request URI looks fine to me.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit e7a1c86.
Since your change was applied there have been 21 commits pushed to the master branch:

• 644d154: 8347474: Options singleton is used before options are parsed
• 3804082: 8346123: [REDO] NMT should not use ThreadCritical
• 1f0efc0: 8347343: RISC-V: Unchecked zicntr csr reads
• ca8ba5c: 8347366: RISC-V: Add extension asserts for CMO instructions
• 0ff6700: 8347987: Bad ifdef in 8330851
• e1cf351: 8348013: [doc] fix typo in java.md caused by JDK-8347763
• 6ef860c: 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed
• 17e3df6: 8347763: [doc] Add documentation of module options for JEP 483
• 6cc1c0a: 8347422: Crash during safepoint handler execution with -XX:+UseAPX
• baca7da: 8347733: Replace SIZE_FORMAT in runtime code
• ... and 11 more: https://git.openjdk.org/jdk/compare/07a0dcbabcb1216211c1da75f6dd2582da194df9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @vy Pushed as commit e7a1c86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.